Bug 122041

Summary:

Message sending functions should only accept rvalues

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Anders Carlsson

Reported 2013-09-27 17:02:00 PDT

Message sending functions should only accept rvalues

Attachments
Patch (14.98 KB, patch) 2013-09-27 17:10 PDT, Anders Carlsson	kling: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2013-09-27 17:10:26 PDT

Created attachment 212856 [details] Patch

WebKit Commit Bot

Comment 2 2013-09-27 17:12:47 PDT

Attachment 212856 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/Platform/CoreIPC/Connection.h', u'Source/WebKit2/Platform/CoreIPC/MessageSender.h', u'Source/WebKit2/Shared/ChildProcessProxy.h', u'Source/WebKit2/UIProcess/WebContext.h', u'Source/WebKit2/UIProcess/WebPageGroup.h']" exit_code: 1 Source/WebKit2/Shared/ChildProcessProxy.h:51: Missing spaces around && [whitespace/operators] [3] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 3 2013-09-28 08:04:52 PDT

Committed r156604: <http://trac.webkit.org/changeset/156604>

Anders Carlsson

Comment 4 2013-09-30 17:47:43 PDT

Committed r156687: <http://trac.webkit.org/changeset/156687>

Note You need to log in before you can comment on or make changes to this bug.