Bug 122041

Summary: Message sending functions should only accept rvalues
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Description Anders Carlsson 2013-09-27 17:02:00 PDT
Message sending functions should only accept rvalues
Comment 1 Anders Carlsson 2013-09-27 17:10:26 PDT
Created attachment 212856 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-27 17:12:47 PDT
Attachment 212856 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/Platform/CoreIPC/Connection.h', u'Source/WebKit2/Platform/CoreIPC/MessageSender.h', u'Source/WebKit2/Shared/ChildProcessProxy.h', u'Source/WebKit2/UIProcess/WebContext.h', u'Source/WebKit2/UIProcess/WebPageGroup.h']" exit_code: 1
Source/WebKit2/Shared/ChildProcessProxy.h:51:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2013-09-28 08:04:52 PDT
Committed r156604: <http://trac.webkit.org/changeset/156604>
Comment 4 Anders Carlsson 2013-09-30 17:47:43 PDT
Committed r156687: <http://trac.webkit.org/changeset/156687>