Bug 122037

Summary: Clean up code for getting first line style
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
another
kling: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion none

Antti Koivisto
Reported 2013-09-27 15:42:02 PDT
We have confusing RenderObject::style(bool firstLine). Get rid of it in favour of just using RenderObject::firstLineStyle() where appropriate.
Attachments
patch (102.24 KB, patch)
2013-09-27 15:48 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
another (103.22 KB, patch)
2013-09-27 16:16 PDT, Antti Koivisto 		kling: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (1.02 MB, application/zip)
2013-09-27 17:13 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (1.06 MB, application/zip)
2013-09-27 17:40 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (1023.21 KB, application/zip)
2013-09-27 18:52 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-09-27 15:48:52 PDT
Created attachment 212848 [details] patch
WebKit Commit Bot
Comment 2 2013-09-27 15:50:16 PDT
Attachment 212848 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/EllipsisBox.cpp', u'Source/WebCore/rendering/InlineBox.cpp', u'Source/WebCore/rendering/InlineBox.h', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderElement.cpp', u'Source/WebCore/rendering/RenderElement.h', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderLineBreak.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RootInlineBox.cpp', u'Source/WebCore/rendering/style/RenderStyle.h', u'Source/WebCore/style/StyleResolveTree.cpp']" exit_code: 1 Source/WebCore/rendering/InlineFlowBox.cpp:172: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/InlineFlowBox.cpp:1342: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/InlineFlowBox.cpp:1350: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/InlineFlowBox.cpp:1351: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebCore/rendering/EllipsisBox.cpp:54: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3 2013-09-27 16:16:15 PDT
Created attachment 212850 [details] another
Andreas Kling
Comment 4 2013-09-27 16:28:55 PDT
Comment on attachment 212850 [details] another View in context: https://bugs.webkit.org/attachment.cgi?id=212850&action=review r=me We really should figure out how to make RenderObject::style() return a reference. > Source/WebCore/ChangeLog:11 > + Also switch to RenderStyle references in many places and move first like style caching Typo, first line.
Build Bot
Comment 5 2013-09-27 17:13:50 PDT
Comment on attachment 212850 [details] another Attachment 212850 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/2651266 New failing tests: fast/ruby/floating-ruby-text.html fast/ruby/float-overhang-from-ruby-text.html fast/ruby/ruby-text-before-after-content.html fast/ruby/position-after.html fast/ruby/text-emphasis.html fast/ruby/overhang-vertical-no-overlap1.html editing/pasteboard/copy-paste-ruby-text-with-block.html editing/pasteboard/copy-paste-ruby-text.html fast/ruby/overhang-horizontal-no-overlap1.html fast/writing-mode/japanese-ruby-horizontal-bt.html fast/text/emphasis-avoid-ruby.html fast/ruby/overhang-vertical-no-overlap2.html fast/ruby/overhang-vertical.html fast/writing-mode/ruby-text-logical-left.html fast/ruby/positioned-ruby-text.html fast/ruby/overhang-horizontal-no-overlap2.html fast/ruby/float-object-doesnt-crash.html fast/ruby/nested-ruby.html fast/ruby/overhang-horizontal.html fast/css/bidi-override-in-anonymous-block.html fast/ruby/text-decoration-in-descendants-ruby.html fast/ruby/ruby-base-merge-block-children-crash.html fast/ruby/ruby-run-break.html
Build Bot
Comment 6 2013-09-27 17:13:52 PDT
Created attachment 212857 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Andreas Kling
Comment 7 2013-09-27 17:17:11 PDT
(In reply to comment #5) > (From update of attachment 212850 [details]) > Attachment 212850 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/2651266 > > New failing tests: I was led to believe this was a mechanical change. :|
Build Bot
Comment 8 2013-09-27 17:40:48 PDT
Comment on attachment 212850 [details] another Attachment 212850 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/2654250 New failing tests: fast/ruby/floating-ruby-text.html fast/ruby/float-overhang-from-ruby-text.html fast/ruby/ruby-text-before-after-content.html fast/ruby/position-after.html fast/ruby/text-emphasis.html fast/ruby/overhang-vertical-no-overlap1.html editing/pasteboard/copy-paste-ruby-text-with-block.html editing/pasteboard/copy-paste-ruby-text.html fast/ruby/overhang-horizontal-no-overlap1.html fast/writing-mode/japanese-ruby-horizontal-bt.html fast/text/emphasis-avoid-ruby.html fast/ruby/overhang-vertical-no-overlap2.html fast/ruby/overhang-vertical.html fast/writing-mode/ruby-text-logical-left.html fast/ruby/positioned-ruby-text.html fast/ruby/overhang-horizontal-no-overlap2.html fast/ruby/float-object-doesnt-crash.html fast/ruby/nested-ruby.html fast/ruby/overhang-horizontal.html fast/css/bidi-override-in-anonymous-block.html fast/ruby/text-decoration-in-descendants-ruby.html fast/ruby/ruby-base-merge-block-children-crash.html fast/ruby/ruby-run-break.html
Build Bot
Comment 9 2013-09-27 17:40:50 PDT
Created attachment 212860 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 10 2013-09-27 18:52:44 PDT
Comment on attachment 212850 [details] another Attachment 212850 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/2676050 New failing tests: fast/ruby/floating-ruby-text.html fast/ruby/float-overhang-from-ruby-text.html fast/ruby/ruby-text-before-after-content.html fast/ruby/position-after.html fast/ruby/text-emphasis.html fast/ruby/overhang-vertical-no-overlap1.html editing/pasteboard/copy-paste-ruby-text-with-block.html editing/pasteboard/copy-paste-ruby-text.html fast/ruby/overhang-horizontal-no-overlap1.html fast/writing-mode/japanese-ruby-horizontal-bt.html fast/text/emphasis-avoid-ruby.html fast/ruby/overhang-vertical-no-overlap2.html fast/ruby/overhang-vertical.html fast/writing-mode/ruby-text-logical-left.html fast/ruby/positioned-ruby-text.html fast/ruby/overhang-horizontal-no-overlap2.html fast/ruby/float-object-doesnt-crash.html fast/ruby/nested-ruby.html fast/ruby/overhang-horizontal.html fast/css/bidi-override-in-anonymous-block.html fast/ruby/text-decoration-in-descendants-ruby.html fast/ruby/ruby-base-merge-block-children-crash.html fast/ruby/ruby-run-break.html
Build Bot
Comment 11 2013-09-27 18:52:46 PDT
Created attachment 212863 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Antti Koivisto
Comment 12 2013-09-28 11:29:32 PDT
https://trac.webkit.org/r156608 (with ruby fixed)
Note You need to log in before you can comment on or make changes to this bug.