Bug 121994

Summary: Workaround template overloading bug in MSVC
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: commit-queue, fpizlo, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2013-09-26 16:14:51 PDT
r156184 broke the Win64 build because of a bug in Visual Studio similar to http://stackoverflow.com/questions/8684583/template-specialization-works-with-g-but-not-with-visual-c A simple workaround is to name setupTwoStubArgs either setupTwoStubArgsGFR or setupTwoStubArgsFPR instead of sharing the name for the overloaded template function.
Attachments
Patch (6.08 KB, patch)
2013-09-26 16:18 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-09-26 16:18:25 PDT
Created attachment 212765 [details] Patch
Alex Christensen
Comment 2 2013-09-26 19:27:47 PDT
By the way, this didn't break the Win32 build because the second one is protected by #if CPU(X86_64), so Visual Studio did not see an overloaded template function with different enum types, which makes the Visual Studio bug cause a compile error.
WebKit Commit Bot
Comment 3 2013-09-27 11:35:02 PDT
Comment on attachment 212765 [details] Patch Clearing flags on attachment: 212765 Committed r156559: <http://trac.webkit.org/changeset/156559>
WebKit Commit Bot
Comment 4 2013-09-27 11:35:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.