Bug 121975

Summary: Pass VM instead of ExecState to many finishCreation() functions.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2013-09-26 13:49:18 PDT 
Less loads.
Comment 1 Andreas Kling 2013-09-26 14:01:21 PDT 
Created attachment 212743 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-26 14:02:42 PDT 
Attachment 212743 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/runtime/ArrayConstructor.cpp', u'Source/JavaScriptCore/runtime/ArrayConstructor.h', u'Source/JavaScriptCore/runtime/BooleanConstructor.cpp', u'Source/JavaScriptCore/runtime/BooleanConstructor.h', u'Source/JavaScriptCore/runtime/BooleanPrototype.cpp', u'Source/JavaScriptCore/runtime/BooleanPrototype.h', u'Source/JavaScriptCore/runtime/DateConstructor.cpp', u'Source/JavaScriptCore/runtime/DateConstructor.h', u'Source/JavaScriptCore/runtime/DatePrototype.cpp', u'Source/JavaScriptCore/runtime/DatePrototype.h', u'Source/JavaScriptCore/runtime/ErrorConstructor.cpp', u'Source/JavaScriptCore/runtime/ErrorConstructor.h', u'Source/JavaScriptCore/runtime/ErrorPrototype.cpp', u'Source/JavaScriptCore/runtime/ErrorPrototype.h', u'Source/JavaScriptCore/runtime/FunctionConstructor.cpp', u'Source/JavaScriptCore/runtime/FunctionConstructor.h', u'Source/JavaScriptCore/runtime/FunctionPrototype.cpp', u'Source/JavaScriptCore/runtime/FunctionPrototype.h', u'Source/JavaScriptCore/runtime/JSAPIValueWrapper.h', u'Source/JavaScriptCore/runtime/JSBoundFunction.cpp', u'Source/JavaScriptCore/runtime/JSFunction.cpp', u'Source/JavaScriptCore/runtime/JSFunction.h', u'Source/JavaScriptCore/runtime/JSNameScope.h', u'Source/JavaScriptCore/runtime/JSPromiseConstructor.cpp', u'Source/JavaScriptCore/runtime/JSPromiseConstructor.h', u'Source/JavaScriptCore/runtime/JSPromisePrototype.cpp', u'Source/JavaScriptCore/runtime/JSPromisePrototype.h', u'Source/JavaScriptCore/runtime/JSPromiseResolverConstructor.cpp', u'Source/JavaScriptCore/runtime/JSPromiseResolverConstructor.h', u'Source/JavaScriptCore/runtime/JSPromiseResolverPrototype.cpp', u'Source/JavaScriptCore/runtime/JSPromiseResolverPrototype.h', u'Source/JavaScriptCore/runtime/JSPropertyNameIterator.cpp', u'Source/JavaScriptCore/runtime/JSPropertyNameIterator.h', u'Source/JavaScriptCore/runtime/MapConstructor.cpp', u'Source/JavaScriptCore/runtime/MapConstructor.h', u'Source/JavaScriptCore/runtime/NameConstructor.cpp', u'Source/JavaScriptCore/runtime/NameConstructor.h', u'Source/JavaScriptCore/runtime/NamePrototype.cpp', u'Source/JavaScriptCore/runtime/NamePrototype.h', u'Source/JavaScriptCore/runtime/NativeErrorPrototype.cpp', u'Source/JavaScriptCore/runtime/NativeErrorPrototype.h', u'Source/JavaScriptCore/runtime/NumberConstructor.cpp', u'Source/JavaScriptCore/runtime/NumberConstructor.h', u'Source/JavaScriptCore/runtime/NumberPrototype.cpp', u'Source/JavaScriptCore/runtime/NumberPrototype.h', u'Source/JavaScriptCore/runtime/ObjectConstructor.cpp', u'Source/JavaScriptCore/runtime/ObjectConstructor.h', u'Source/JavaScriptCore/runtime/RegExpConstructor.cpp', u'Source/JavaScriptCore/runtime/RegExpConstructor.h', u'Source/JavaScriptCore/runtime/SetConstructor.cpp', u'Source/JavaScriptCore/runtime/SetConstructor.h', u'Source/JavaScriptCore/runtime/StringConstructor.cpp', u'Source/JavaScriptCore/runtime/StringConstructor.h', u'Source/JavaScriptCore/runtime/WeakMapConstructor.cpp', u'Source/JavaScriptCore/runtime/WeakMapConstructor.h']" exit_code: 1
Source/JavaScriptCore/runtime/ObjectConstructor.h:54:  The parameter name "vm" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 56 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2013-09-26 14:42:38 PDT 
Comment on attachment 212743 [details]
Patch

Clearing flags on attachment: 212743

Committed r156498: <http://trac.webkit.org/changeset/156498>
Comment 4 WebKit Commit Bot 2013-09-26 14:42:40 PDT 
All reviewed patches have been landed.  Closing bug.