Bug 121961

Summary: [Qt] Fix force_static_libs_as_shared in WebKit2
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Tools / TestsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, commit-queue, hausmann, menard, ossy, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Allan Sandfeld Jensen 2013-09-26 09:37:37 PDT 
force_static_libs_as_shared has been disabled for some time because WebKit2 does not build with it enabled.
Comment 1 Allan Sandfeld Jensen 2013-09-26 09:41:55 PDT 
Created attachment 212719 [details]
Patch
Comment 2 Allan Sandfeld Jensen 2013-09-27 04:38:45 PDT 
Created attachment 212797 [details]
Patch
Comment 3 Csaba Osztrogonác 2013-09-27 04:41:59 PDT 
Comment on attachment 212797 [details]
Patch

rs=me.
Comment 4 Allan Sandfeld Jensen 2013-09-27 05:15:10 PDT 
Comment on attachment 212797 [details]
Patch

Clearing flags on attachment: 212797

Committed r156535: <http://trac.webkit.org/changeset/156535>
Comment 5 Allan Sandfeld Jensen 2013-09-27 05:15:15 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Csaba Osztrogonác 2013-09-30 02:27:15 PDT 
(In reply to comment #4)
> (From update of attachment 212797 [details])
> Clearing flags on attachment: 212797
> 
> Committed r156535: <http://trac.webkit.org/changeset/156535>

It seems something went wrong, because it broke the MIPS build.
Comment 7 Allan Sandfeld Jensen 2013-09-30 03:43:24 PDT 
Yes, I was missing one part.
Comment 8 Allan Sandfeld Jensen 2013-09-30 04:14:40 PDT 
Created attachment 212976 [details]
Patch
Comment 9 Early Warning System Bot 2013-09-30 04:18:24 PDT 
Comment on attachment 212976 [details]
Patch

Attachment 212976 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2812032
Comment 10 Allan Sandfeld Jensen 2013-09-30 04:33:50 PDT 
Comment on attachment 212976 [details]
Patch

Untagging for review. This has a typo and is essentially just emptying webkit2qml, so we might as well remove webkit2qml.
Comment 11 Allan Sandfeld Jensen 2013-09-30 05:14:50 PDT 
Created attachment 212983 [details]
Patch
Comment 12 Csaba Osztrogonác 2013-09-30 08:21:21 PDT 
Comment on attachment 212983 [details]
Patch

rs=me
Comment 13 WebKit Commit Bot 2013-09-30 09:29:31 PDT 
Comment on attachment 212983 [details]
Patch

Clearing flags on attachment: 212983

Committed r156658: <http://trac.webkit.org/changeset/156658>
Comment 14 WebKit Commit Bot 2013-09-30 09:29:34 PDT 
All reviewed patches have been landed.  Closing bug.