Bug 121933

Summary: Do not reenter Document from its destructor
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kangil.han, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Benjamin Poulain
Reported 2013-09-25 18:07:59 PDT
Do not reenter Document from its destructor
Attachments
Patch (5.64 KB, patch)
2013-09-25 18:15 PDT, Benjamin Poulain 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-09-25 18:15:07 PDT
Created attachment 212648 [details] Patch
Darin Adler
Comment 2 2013-09-25 18:56:37 PDT
Comment on attachment 212648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212648&action=review No regression test? > Source/WebCore/css/CSSStyleSheet.h:114 > + void detachFromDocument() { m_ownerNode = 0; } nullptr > Source/WebCore/dom/DocumentStyleSheetCollection.cpp:505 > } > > + > +void DocumentStyleSheetCollection::detachFromDocument() Looks like there is an extra blank line here.
Benjamin Poulain
Comment 3 2013-09-25 20:06:12 PDT
Committed r156444: <http://trac.webkit.org/changeset/156444>
Note You need to log in before you can comment on or make changes to this bug.