| Summary: | SVG gradients do not invalidate correctly when stops change color via style accessors | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | hyatt, zimmermann | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 420+ | ||||||||||
| Hardware: | Mac | ||||||||||
| OS: | OS X 10.4 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Eric Seidel (no email)
2007-01-10 02:54:55 PST
Created attachment 12342 [details]
test case
Hyatt said that the way to hear about style changes, it to have a renderer, and then setStyle will be called on that renderer when the style changes. We may need to have add renderers for SVGStopElements if that's the case. That might also make style resolution easier too. This is fixed in my local tree, patch forthcoming. Created attachment 12871 [details]
code changes
These changes fix this bug as well as 12498
Created attachment 12872 [details]
test result updates
These are mostly updates from changing RenderSVGContainer to RenderSVGHiddenContainer for <defs> and gradients.
(In reply to comment #5) > Created an attachment (id=12872) [edit] > test result updates > > These are mostly updates from changing RenderSVGContainer to > RenderSVGHiddenContainer for <defs> and gradients. Excellent patch! This is the way to go. (I started working on a very similar patch a while ago :-) Niko Comment on attachment 12871 [details]
code changes
r=me!
|