Bug 12193

Summary: SVG gradients do not invalidate correctly when stops change color via style accessors
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, zimmermann
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
test case
none
code changes
mitz: review+
test result updates sam: review+

Eric Seidel (no email)
Reported 2007-01-10 02:54:55 PST
SVG gradients do not invalidate correctly when stops change color via style accessors See test case. Neither FF nor Opera seem to support style.stopColor correctly either though. We support it, but not with proper invalidation.
Attachments
test case (444 bytes, image/svg+xml)
2007-01-10 02:55 PST, Eric Seidel (no email) 		no flags
Details
code changes (29.41 KB, patch)
2007-02-02 07:59 PST, Eric Seidel (no email) 		mitz: review+
DetailsFormatted DiffDiff
test result updates (286.83 KB, patch)
2007-02-02 08:01 PST, Eric Seidel (no email) 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2007-01-10 02:55:31 PST
Created attachment 12342 [details] test case
Eric Seidel (no email)
Comment 2 2007-01-15 01:42:54 PST
Hyatt said that the way to hear about style changes, it to have a renderer, and then setStyle will be called on that renderer when the style changes. We may need to have add renderers for SVGStopElements if that's the case. That might also make style resolution easier too.
Eric Seidel (no email)
Comment 3 2007-02-02 07:27:10 PST
This is fixed in my local tree, patch forthcoming.
Eric Seidel (no email)
Comment 4 2007-02-02 07:59:53 PST
Created attachment 12871 [details] code changes These changes fix this bug as well as 12498
Eric Seidel (no email)
Comment 5 2007-02-02 08:01:15 PST
Created attachment 12872 [details] test result updates These are mostly updates from changing RenderSVGContainer to RenderSVGHiddenContainer for <defs> and gradients.
Nikolas Zimmermann
Comment 6 2007-02-02 08:25:22 PST
(In reply to comment #5) > Created an attachment (id=12872) [edit] > test result updates > > These are mostly updates from changing RenderSVGContainer to > RenderSVGHiddenContainer for <defs> and gradients. Excellent patch! This is the way to go. (I started working on a very similar patch a while ago :-) Niko
mitz
Comment 7 2007-02-02 08:40:47 PST
Comment on attachment 12871 [details] code changes r=me!
Eric Seidel (no email)
Comment 8 2007-02-02 08:46:07 PST
r19362
Note You need to log in before you can comment on or make changes to this bug.