Bug 121845

Summary: Make hoverAncestor() a RenderElement concept.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kangil.han, kondapallykalyan, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+
For landing
none
Patch for landing
none
Patch for landing none

Andreas Kling
Reported 2013-09-24 09:59:08 PDT
Make hoverAncestor() a RenderElement concept.
Attachments
Patch (12.77 KB, patch)
2013-09-24 10:04 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
For landing (15.14 KB, patch)
2013-09-24 10:12 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.94 KB, patch)
2013-09-24 10:22 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.62 KB, patch)
2013-09-24 10:30 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-24 10:04:50 PDT
Created attachment 212475 [details] Patch
Antti Koivisto
Comment 2 2013-09-24 10:07:41 PDT
Comment on attachment 212475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212475&action=review > Source/WebCore/rendering/RenderElement.cpp:951 > + hoverAncestor = toRenderElement(domAncestorNode->renderer()); I guess we really should make ContainerNode::renderer() return RenderElement.
Andreas Kling
Comment 3 2013-09-24 10:12:00 PDT
Created attachment 212476 [details] For landing
Andreas Kling
Comment 4 2013-09-24 10:22:10 PDT
Created attachment 212478 [details] Patch for landing
Andreas Kling
Comment 5 2013-09-24 10:30:50 PDT
Created attachment 212479 [details] Patch for landing Why is this so hard.
WebKit Commit Bot
Comment 6 2013-09-24 10:50:07 PDT
Comment on attachment 212479 [details] Patch for landing Clearing flags on attachment: 212479 Committed r156338: <http://trac.webkit.org/changeset/156338>
WebKit Commit Bot
Comment 7 2013-09-24 10:50:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.