Bug 121823

Summary: Use unique_ptr instead of deleteAllValues in FloatingObject code
Product: WebKit Reporter: Darin Adler <darin>
Component: Layout and RenderingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch sam: review+

Darin Adler
Reported 2013-09-23 22:00:50 PDT
Use unique_ptr instead of deleteAllValues in FloatingObject code
Attachments
Patch (59.57 KB, patch)
2013-09-23 22:21 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (59.78 KB, patch)
2013-09-23 22:40 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (59.79 KB, patch)
2013-09-23 22:47 PDT, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-09-23 22:21:51 PDT
Created attachment 212426 [details] Patch
Early Warning System Bot
Comment 2 2013-09-23 22:29:42 PDT
Comment on attachment 212426 [details] Patch Attachment 212426 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1976114
Early Warning System Bot
Comment 3 2013-09-23 22:31:18 PDT
Comment on attachment 212426 [details] Patch Attachment 212426 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1903306
Darin Adler
Comment 4 2013-09-23 22:40:29 PDT
Created attachment 212427 [details] Patch
EFL EWS Bot
Comment 5 2013-09-23 22:45:56 PDT
Comment on attachment 212427 [details] Patch Attachment 212427 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/2004503
Early Warning System Bot
Comment 6 2013-09-23 22:46:20 PDT
Comment on attachment 212427 [details] Patch Attachment 212427 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1806248
Darin Adler
Comment 7 2013-09-23 22:47:19 PDT
Created attachment 212428 [details] Patch
Darin Adler
Comment 8 2013-09-23 22:52:41 PDT
Committed r156319: <http://trac.webkit.org/changeset/156319>
Note You need to log in before you can comment on or make changes to this bug.