Bug 121802

Summary: ListHashSet should work with move-only types
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2013-09-23 14:04:15 PDT
ListHashSet should work with move-only types
Attachments
Patch (11.43 KB, patch)
2013-09-23 14:09 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-09-23 14:09:45 PDT
Created attachment 212389 [details] Patch
WebKit Commit Bot
Comment 2 2013-09-23 14:12:54 PDT
Attachment 212389 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/ListHashSet.h', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/Tests/WTF/ListHashSet.cpp']" exit_code: 1 Source/WTF/wtf/ListHashSet.h:126: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/ListHashSet.h:131: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/ListHashSet.h:136: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/ListHashSet.h:141: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/ListHashSet.h:599: This { should be at the end of the previous line [whitespace/braces] [4] Source/WTF/wtf/ListHashSet.h:620: This { should be at the end of the previous line [whitespace/braces] [4] Source/WTF/wtf/ListHashSet.h:644: This { should be at the end of the previous line [whitespace/braces] [4] Source/WTF/wtf/ListHashSet.h:656: This { should be at the end of the previous line [whitespace/braces] [4] Source/WTF/wtf/ListHashSet.h:662: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 9 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2013-09-23 14:38:51 PDT
Committed r156294: <http://trac.webkit.org/changeset/156294>
Note You need to log in before you can comment on or make changes to this bug.