Bug 121783 – [GTK][WK2] --disalble-credential-storage does not hide remember password checkbox

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Manuel Rego Casasnovas]

In WebKitGTK+ 2.0.4 and WK2 --disalble-credential-storage does not hide the checkbox used to remember passwords.

[Manuel Rego Casasnovas]

Created attachment 212340 [details]
Patch

[Manuel Rego Casasnovas]

(In reply to comment #1)
> Created an attachment (id=212340) [details]
> Patch

Current patch applies in trunk and it's fixing the issue in the widget directly.

There's a different alternative to fix this problem, similar to current code (that won't apply in trunk):
diff --git a/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp b/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
index 0d9df77..bc43489 100644
--- a/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
+++ b/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
@@ -1740,10 +1740,13 @@ void webkitWebViewSubmitFormRequest(WebKitWebView* webView, WebKitFormSubmission
 void webkitWebViewHandleAuthenticationChallenge(WebKitWebView* webView, AuthenticationChallengeProxy* authenticationChallenge)
 {
     CredentialStorageMode credentialStorageMode;
-    if (webkit_settings_get_enable_private_browsing(webkit_web_view_get_settings(webView)))
-        credentialStorageMode = DisallowPersistentStorage;
-    else
+#if ENABLE(CREDENTIAL_STORAGE)
+    if (!webkit_settings_get_enable_private_browsing(webkit_web_view_get_settings(webView)))
         credentialStorageMode = AllowPersistentStorage;
+    else
+#else
+        credentialStorageMode = DisallowPersistentStorage;
+#endif
 
     webkitWebViewBaseAddAuthenticationDialog(WEBKIT_WEB_VIEW_BASE(webView), webkitAuthenticationDialogNew(authenticationChallenge, credentialStorageMode));
 }

The new API has already a similar #if (see http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationRequest.cpp#L143).

Please tell me your preferences and I can provide a different patch if required :-)

[Martin Robinson]

I think the alternative fix is the way to go.

[Manuel Rego Casasnovas]

Created attachment 212353 [details]
Patch

Patch implementing the other alternative. Take into account that this doesn't apply in trunk.

[Martin Robinson]

Why won't the patch apply in trunk?

[Manuel Rego Casasnovas]

(In reply to comment #5)
> Why won't the patch apply in trunk?

This code has changed, since we added the new API to configure the authentication dialogue. For example, see http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationRequest.cpp#L143

The problem is not present in trunk or in the last releases.

So, this patch only apply in webkit-2.0 branch (or in a tar of our last stable release 2.0.4).

[Martin Robinson]

Ah, I see. Are we going to ship any more 2.0.x releases?

[Manuel Rego Casasnovas]

(In reply to comment #7)
> Ah, I see. Are we going to ship any more 2.0.x releases?

According to CarlosGC yes.

We've already merged some patches as you can see in: https://trac.webkit.org/wiki/WebKitGTK/2.0.x

[Michael Catanzaro]

Obsolete -> fixed ?