| Summary: | [GTK][WK2] --disalble-credential-storage does not hide remember password checkbox | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||
| Component: | WebKitGTK | Assignee: | Manuel Rego Casasnovas <rego> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cgarcia, mcatanzaro, mrobinson | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Manuel Rego Casasnovas
2013-09-23 04:42:34 PDT
Created attachment 212340 [details]
Patch
(In reply to comment #1) > Created an attachment (id=212340) [details] > Patch Current patch applies in trunk and it's fixing the issue in the widget directly. There's a different alternative to fix this problem, similar to current code (that won't apply in trunk): diff --git a/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp b/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp index 0d9df77..bc43489 100644 --- a/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp +++ b/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp @@ -1740,10 +1740,13 @@ void webkitWebViewSubmitFormRequest(WebKitWebView* webView, WebKitFormSubmission void webkitWebViewHandleAuthenticationChallenge(WebKitWebView* webView, AuthenticationChallengeProxy* authenticationChallenge) { CredentialStorageMode credentialStorageMode; - if (webkit_settings_get_enable_private_browsing(webkit_web_view_get_settings(webView))) - credentialStorageMode = DisallowPersistentStorage; - else +#if ENABLE(CREDENTIAL_STORAGE) + if (!webkit_settings_get_enable_private_browsing(webkit_web_view_get_settings(webView))) credentialStorageMode = AllowPersistentStorage; + else +#else + credentialStorageMode = DisallowPersistentStorage; +#endif webkitWebViewBaseAddAuthenticationDialog(WEBKIT_WEB_VIEW_BASE(webView), webkitAuthenticationDialogNew(authenticationChallenge, credentialStorageMode)); } The new API has already a similar #if (see http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationRequest.cpp#L143). Please tell me your preferences and I can provide a different patch if required :-) I think the alternative fix is the way to go. Created attachment 212353 [details]
Patch
Patch implementing the other alternative. Take into account that this doesn't apply in trunk.
Why won't the patch apply in trunk? (In reply to comment #5) > Why won't the patch apply in trunk? This code has changed, since we added the new API to configure the authentication dialogue. For example, see http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationRequest.cpp#L143 The problem is not present in trunk or in the last releases. So, this patch only apply in webkit-2.0 branch (or in a tar of our last stable release 2.0.4). Ah, I see. Are we going to ship any more 2.0.x releases? (In reply to comment #7) > Ah, I see. Are we going to ship any more 2.0.x releases? According to CarlosGC yes. We've already merged some patches as you can see in: https://trac.webkit.org/wiki/WebKitGTK/2.0.x Obsolete -> fixed ? |