Bug 121770

Summary: Add empty MainFrame class
Product: WebKit Reporter: Darin Adler <darin>
Component: Page LoadingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andersca, apinheiro, brian.holt, cdumez, cfleizach, cmarcelo, commit-queue, dmazzoni, dpranke, d-r, eflews.bot, eric.carlson, esprehn+autocc, fmalita, glenn, gtk-ews, gyuyoung.kim, jamesr, japhet, jberlin, jdiggs, jer.noble, kangil.han, kondapallykalyan, luiz, macpherson, mario, menard, noam, pdr, philn, rakuco, schenney, tonikitoo, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
buildbot: commit-queue-
Patch none

Description Darin Adler 2013-09-22 16:21:33 PDT 
Add empty MainFrame class
Comment 1 Darin Adler 2013-09-22 16:27:43 PDT 
Created attachment 212308 [details]
Patch
Comment 2 Andreas Kling 2013-09-22 16:35:04 PDT 
Comment on attachment 212308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212308&action=review

EWS seems unhappy.

> Source/WebCore/page/Page.cpp:145
> -    , m_mainFrame(Frame::create(this, 0, pageClients.loaderClientForMainFrame))
> +    , m_mainFrame(MainFrame::create(*this, *pageClients.loaderClientForMainFrame).get())

What's with the .get() here?
Comment 3 Early Warning System Bot 2013-09-22 16:35:09 PDT 
Comment on attachment 212308 [details]
Patch

Attachment 212308 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2071058
Comment 4 Early Warning System Bot 2013-09-22 16:35:47 PDT 
Comment on attachment 212308 [details]
Patch

Attachment 212308 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2033191
Comment 5 Darin Adler 2013-09-22 16:46:23 PDT 
Comment on attachment 212308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212308&action=review

>> Source/WebCore/page/Page.cpp:145
>> +    , m_mainFrame(MainFrame::create(*this, *pageClients.loaderClientForMainFrame).get())
> 
> What's with the .get() here?

Left over from when I was trying to use Ref here instead of RefPtr/PassRefPtr for this never null pointer. Fixed in my next version.
Comment 6 Darin Adler 2013-09-22 16:46:54 PDT 
(In reply to comment #2)
> EWS seems unhappy.

Yes, I’m sure we’ll have to add more includes for platforms other than Mac.
Comment 7 Darin Adler 2013-09-22 16:51:42 PDT 
Created attachment 212309 [details]
Patch
Comment 8 Early Warning System Bot 2013-09-22 16:59:18 PDT 
Comment on attachment 212309 [details]
Patch

Attachment 212309 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2004380
Comment 9 Early Warning System Bot 2013-09-22 16:59:43 PDT 
Comment on attachment 212309 [details]
Patch

Attachment 212309 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2004379
Comment 10 Darin Adler 2013-09-22 17:04:17 PDT 
Created attachment 212310 [details]
Patch
Comment 11 EFL EWS Bot 2013-09-22 17:10:43 PDT 
Comment on attachment 212310 [details]
Patch

Attachment 212310 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1928298
Comment 12 Early Warning System Bot 2013-09-22 17:11:17 PDT 
Comment on attachment 212310 [details]
Patch

Attachment 212310 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1881423
Comment 13 Early Warning System Bot 2013-09-22 17:13:33 PDT 
Comment on attachment 212310 [details]
Patch

Attachment 212310 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1844299
Comment 14 Darin Adler 2013-09-22 17:26:35 PDT 
Created attachment 212311 [details]
Patch
Comment 15 Early Warning System Bot 2013-09-22 17:33:11 PDT 
Comment on attachment 212311 [details]
Patch

Attachment 212311 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1979033
Comment 16 Early Warning System Bot 2013-09-22 17:35:40 PDT 
Comment on attachment 212311 [details]
Patch

Attachment 212311 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1800247
Comment 17 EFL EWS Bot 2013-09-22 17:45:38 PDT 
Comment on attachment 212311 [details]
Patch

Attachment 212311 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1936021
Comment 18 EFL EWS Bot 2013-09-22 17:48:15 PDT 
Comment on attachment 212311 [details]
Patch

Attachment 212311 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/2090054
Comment 19 Darin Adler 2013-09-22 17:53:01 PDT 
Created attachment 212312 [details]
Patch
Comment 20 WebKit Commit Bot 2013-09-22 17:57:46 PDT 
Attachment 212312 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/history/CachedPage.cpp', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/HistoryController.cpp', u'Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameTree.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/GestureTapHighlighter.cpp', u'Source/WebCore/page/MainFrame.cpp', u'Source/WebCore/page/MainFrame.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/page/PageGroupLoadDeferrer.cpp', u'Source/WebCore/page/PageSerializer.cpp', u'Source/WebCore/page/PageThrottler.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/mac/DragControllerMac.mm', u'Source/WebCore/page/mac/PageMac.cpp', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp', u'Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm', u'Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/storage/StorageEventDispatcher.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/InternalSettings.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebDragClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp', u'Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebCore/page/MainFrame.cpp:37:  The return type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 1 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 21 Early Warning System Bot 2013-09-22 17:59:52 PDT 
Comment on attachment 212312 [details]
Patch

Attachment 212312 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1936023
Comment 22 Early Warning System Bot 2013-09-22 18:02:07 PDT 
Comment on attachment 212312 [details]
Patch

Attachment 212312 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2102011
Comment 23 EFL EWS Bot 2013-09-22 18:04:45 PDT 
Comment on attachment 212312 [details]
Patch

Attachment 212312 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/2050015
Comment 24 EFL EWS Bot 2013-09-22 18:08:37 PDT 
Comment on attachment 212312 [details]
Patch

Attachment 212312 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1892402
Comment 25 kov's GTK+ EWS bot 2013-09-22 18:21:10 PDT 
Comment on attachment 212312 [details]
Patch

Attachment 212312 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/2065117
Comment 26 Darin Adler 2013-09-22 22:57:06 PDT 
Created attachment 212323 [details]
Patch
Comment 27 WebKit Commit Bot 2013-09-22 23:00:20 PDT 
Attachment 212323 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/history/CachedPage.cpp', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/HistoryController.cpp', u'Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameTree.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/GestureTapHighlighter.cpp', u'Source/WebCore/page/MainFrame.cpp', u'Source/WebCore/page/MainFrame.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/page/PageGroupLoadDeferrer.cpp', u'Source/WebCore/page/PageSerializer.cpp', u'Source/WebCore/page/PageThrottler.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/mac/DragControllerMac.mm', u'Source/WebCore/page/mac/PageMac.cpp', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp', u'Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm', u'Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/storage/StorageEventDispatcher.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/InternalSettings.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp', u'Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebDragClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp', u'Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebCore/page/MainFrame.cpp:37:  The return type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 1 in 103 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 28 EFL EWS Bot 2013-09-22 23:12:00 PDT 
Comment on attachment 212323 [details]
Patch

Attachment 212323 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1907609
Comment 29 kov's GTK+ EWS bot 2013-09-22 23:51:22 PDT 
Comment on attachment 212323 [details]
Patch

Attachment 212323 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/2048105
Comment 30 Darin Adler 2013-09-23 09:16:54 PDT 
Created attachment 212354 [details]
Patch
Comment 31 Darin Adler 2013-09-23 10:14:54 PDT 
Created attachment 212360 [details]
Patch
Comment 32 WebKit Commit Bot 2013-09-23 19:31:02 PDT 
Attachment 212360 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/history/CachedPage.cpp', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/HistoryController.cpp', u'Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameTree.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/GestureTapHighlighter.cpp', u'Source/WebCore/page/MainFrame.cpp', u'Source/WebCore/page/MainFrame.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/page/PageGroupLoadDeferrer.cpp', u'Source/WebCore/page/PageSerializer.cpp', u'Source/WebCore/page/PageThrottler.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/mac/DragControllerMac.mm', u'Source/WebCore/page/mac/PageMac.cpp', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp', u'Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm', u'Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/storage/StorageEventDispatcher.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/InternalSettings.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp', u'Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebDragClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp', u'Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebCore/page/MainFrame.cpp:37:  The return type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 1 in 107 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 33 EFL EWS Bot 2013-09-23 21:17:17 PDT 
Comment on attachment 212360 [details]
Patch

Attachment 212360 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/2075110
Comment 34 kov's GTK+ EWS bot 2013-09-23 22:53:39 PDT 
Comment on attachment 212360 [details]
Patch

Attachment 212360 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/2092185
Comment 35 Darin Adler 2013-09-23 23:54:09 PDT 
Created attachment 212432 [details]
Patch
Comment 36 WebKit Commit Bot 2013-09-24 07:13:34 PDT 
Attachment 212432 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/history/CachedPage.cpp', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/HistoryController.cpp', u'Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameTree.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/GestureTapHighlighter.cpp', u'Source/WebCore/page/MainFrame.cpp', u'Source/WebCore/page/MainFrame.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/page/PageGroupLoadDeferrer.cpp', u'Source/WebCore/page/PageSerializer.cpp', u'Source/WebCore/page/PageThrottler.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/mac/DragControllerMac.mm', u'Source/WebCore/page/mac/PageMac.cpp', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp', u'Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm', u'Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/storage/StorageEventDispatcher.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/InternalSettings.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp', u'Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebDragClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp', u'Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebCore/page/MainFrame.cpp:37:  The return type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 1 in 109 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 37 kov's GTK+ EWS bot 2013-09-24 07:25:00 PDT 
Comment on attachment 212432 [details]
Patch

Attachment 212432 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1908482
Comment 38 Darin Adler 2013-09-24 09:11:18 PDT 
Created attachment 212473 [details]
Patch
Comment 39 WebKit Commit Bot 2013-09-24 09:17:05 PDT 
Attachment 212473 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/history/CachedPage.cpp', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/HistoryController.cpp', u'Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameTree.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/GestureTapHighlighter.cpp', u'Source/WebCore/page/MainFrame.cpp', u'Source/WebCore/page/MainFrame.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/page/PageGroupLoadDeferrer.cpp', u'Source/WebCore/page/PageSerializer.cpp', u'Source/WebCore/page/PageThrottler.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/mac/DragControllerMac.mm', u'Source/WebCore/page/mac/PageMac.cpp', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp', u'Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm', u'Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/storage/StorageEventDispatcher.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/InternalSettings.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp', u'Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp', u'Source/WebKit/gtk/webkit/webkitviewportattributes.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebDragClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp', u'Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebCore/page/MainFrame.cpp:37:  The return type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 1 in 110 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 40 kov's GTK+ EWS bot 2013-09-24 09:21:07 PDT 
Comment on attachment 212473 [details]
Patch

Attachment 212473 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1864710
Comment 41 Build Bot 2013-09-24 11:49:44 PDT 
Comment on attachment 212473 [details]
Patch

Attachment 212473 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/2110286
Comment 42 Darin Adler 2013-09-26 07:54:46 PDT 
Created attachment 212709 [details]
Patch
Comment 43 WebKit Commit Bot 2013-09-26 09:15:02 PDT 
Attachment 212709 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptProfiler.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/history/CachedPage.cpp', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/HistoryController.cpp', u'Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp', u'Source/WebCore/page/AutoscrollController.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameTree.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/GestureTapHighlighter.cpp', u'Source/WebCore/page/MainFrame.cpp', u'Source/WebCore/page/MainFrame.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/page/PageGroupLoadDeferrer.cpp', u'Source/WebCore/page/PageSerializer.cpp', u'Source/WebCore/page/PageThrottler.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/mac/DragControllerMac.mm', u'Source/WebCore/page/mac/PageMac.cpp', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp', u'Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm', u'Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/storage/StorageEventDispatcher.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/InternalSettings.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp', u'Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp', u'Source/WebKit/gtk/webkit/webkitviewportattributes.cpp', u'Source/WebKit/gtk/webkit/webkitwebframe.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebDragClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp', u'Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebCore/page/MainFrame.cpp:37:  The return type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 1 in 112 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 44 kov's GTK+ EWS bot 2013-09-26 09:37:36 PDT 
Comment on attachment 212709 [details]
Patch

Attachment 212709 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/2442005
Comment 45 Build Bot 2013-09-26 10:00:26 PDT 
Comment on attachment 212709 [details]
Patch

Attachment 212709 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/2467001
Comment 46 Darin Adler 2013-09-26 18:29:27 PDT 
Created attachment 212780 [details]
Patch
Comment 47 Build Bot 2013-09-27 00:08:53 PDT 
Comment on attachment 212780 [details]
Patch

Attachment 212780 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/2649080
Comment 48 Brian Holt 2013-09-27 02:31:34 PDT 
The GTK (WK1) build needs an include "MainFrame.h" in Source/WebKit/gtk/webkit/webkitwebview.cpp.  After that GTK builds and all the unit tests pass.
Comment 49 kov's GTK+ EWS bot 2013-09-27 05:14:41 PDT 
Comment on attachment 212780 [details]
Patch

Attachment 212780 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/2652108
Comment 50 Andreas Kling 2013-09-27 05:23:12 PDT 
Created attachment 212798 [details]
Patch
Comment 51 Darin Adler 2013-09-27 08:07:45 PDT 
Committed r156543: <http://trac.webkit.org/changeset/156543>
Comment 52 Jessie Berlin 2013-09-27 09:20:56 PDT 
It looks like http://trac.webkit.org/changeset/156543 broke the webkitpy tests:

http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/10442/steps/webkitpy-test/logs/stdio

Running the tests ...
[1103/1467] webkitpy.style.checkers.cpp_unittest.FunctionDetectionTest.test_basic_function_detection erred:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 408, in test_basic_function_detection
      'is_declaration': False})
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 377, in perform_function_detection
      self.assertEqual(function_state.modifiers_and_return_type(), function_information['modifiers_and_return_type'])
  AttributeError: '_FunctionState' object has no attribute 'modifiers_and_return_type'
  
[1109/1467] webkitpy.style.checkers.cpp_unittest.FunctionDetectionTest.test_function_declaration_detection erred:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 421, in test_function_declaration_detection
      'is_declaration': True})
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 377, in perform_function_detection
      self.assertEqual(function_state.modifiers_and_return_type(), function_information['modifiers_and_return_type'])
  AttributeError: '_FunctionState' object has no attribute 'modifiers_and_return_type'
  
[1121/1467] webkitpy.style.checkers.cpp_unittest.FunctionDetectionTest.test_non_functions erred:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 530, in test_non_functions
      'is_declaration': True})
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 377, in perform_function_detection
      self.assertEqual(function_state.modifiers_and_return_type(), function_information['modifiers_and_return_type'])
  AttributeError: '_FunctionState' object has no attribute 'modifiers_and_return_type'
  
[1127/1467] webkitpy.style.checkers.cpp_unittest.FunctionDetectionTest.test_parameter_list erred:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 548, in test_parameter_list
      'parameter_list': ()})
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 377, in perform_function_detection
      self.assertEqual(function_state.modifiers_and_return_type(), function_information['modifiers_and_return_type'])
  AttributeError: '_FunctionState' object has no attribute 'modifiers_and_return_type'
  
[1133/1467] webkitpy.style.checkers.cpp_unittest.FunctionDetectionTest.test_pure_function_detection erred:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 482, in test_pure_function_detection
      'is_declaration': True})
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 377, in perform_function_detection
      self.assertEqual(function_state.modifiers_and_return_type(), function_information['modifiers_and_return_type'])
  AttributeError: '_FunctionState' object has no attribute 'modifiers_and_return_type'
Comment 53 Jessie Berlin 2013-09-27 09:21:44 PDT 
It looks like http://trac.webkit.org/changeset/156543 broke the webkitpy tests:

http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/10442/steps/webkitpy-test/logs/stdio

Running the tests ...
[1103/1467] webkitpy.style.checkers.cpp_unittest.FunctionDetectionTest.test_basic_function_detection erred:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 408, in test_basic_function_detection
      'is_declaration': False})
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 377, in perform_function_detection
      self.assertEqual(function_state.modifiers_and_return_type(), function_information['modifiers_and_return_type'])
  AttributeError: '_FunctionState' object has no attribute 'modifiers_and_return_type'
  
[1109/1467] webkitpy.style.checkers.cpp_unittest.FunctionDetectionTest.test_function_declaration_detection erred:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 421, in test_function_declaration_detection
      'is_declaration': True})
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 377, in perform_function_detection
      self.assertEqual(function_state.modifiers_and_return_type(), function_information['modifiers_and_return_type'])
  AttributeError: '_FunctionState' object has no attribute 'modifiers_and_return_type'
  
[1121/1467] webkitpy.style.checkers.cpp_unittest.FunctionDetectionTest.test_non_functions erred:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 530, in test_non_functions
      'is_declaration': True})
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 377, in perform_function_detection
      self.assertEqual(function_state.modifiers_and_return_type(), function_information['modifiers_and_return_type'])
  AttributeError: '_FunctionState' object has no attribute 'modifiers_and_return_type'
  
[1127/1467] webkitpy.style.checkers.cpp_unittest.FunctionDetectionTest.test_parameter_list erred:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 548, in test_parameter_list
      'parameter_list': ()})
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 377, in perform_function_detection
      self.assertEqual(function_state.modifiers_and_return_type(), function_information['modifiers_and_return_type'])
  AttributeError: '_FunctionState' object has no attribute 'modifiers_and_return_type'
  
[1133/1467] webkitpy.style.checkers.cpp_unittest.FunctionDetectionTest.test_pure_function_detection erred:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 482, in test_pure_function_detection
      'is_declaration': True})
    File "/Volumes/Data/slave/mountainlion-debug-tests-wk1/build/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py", line 377, in perform_function_detection
      self.assertEqual(function_state.modifiers_and_return_type(), function_information['modifiers_and_return_type'])
  AttributeError: '_FunctionState' object has no attribute 'modifiers_and_return_type'