Bug 121720

Summary: WebFontDescription needs different declaration in DOMPrivate.idl
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Trivial CC: bfulgham, paroga, sfalken
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
patch none

Alex Christensen
Reported 2013-09-20 14:46:23 PDT
Back in the stone age (http://trac.webkit.org/changeset/27755) Steve added a declaration of WebFontDescription that worked with Visual Studio up through VS2010. VS2012 does not like this declaration, but it can be fixed simply without breaking anything. The idl file requires "interface WebFontDescription;" but WebKit.h that is generated from the idl file requires "typedef struct WebFontDescription WebFontDescription;", so using the cpp_quote MIDL attribute puts that string into WebKit.h.
Attachments
Patch (222 bytes, patch)
2013-09-20 14:57 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
patch (1022 bytes, patch)
2013-09-20 14:59 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-09-20 14:57:21 PDT
Created attachment 212224 [details] Patch
Alex Christensen
Comment 2 2013-09-20 14:59:17 PDT
Created attachment 212225 [details] patch
Alex Christensen
Comment 3 2013-09-20 15:39:14 PDT
*** This bug has been marked as a duplicate of bug 121552 ***
Brent Fulgham
Comment 4 2013-09-20 16:54:21 PDT
Yeah -- this is a better patch than the one paroga landed. I think we should use *this* version.
Alex Christensen
Comment 5 2013-09-21 17:12:20 PDT
I like Patrick's solution. There's no reason to have the interface declaration and the typedef when just having "struct WebFontDescription" in one location works.
Note You need to log in before you can comment on or make changes to this bug.