Bug 121706

Summary:

Remove unused code in WebKit/mac's WebScriptDebugDelegate

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

WebKit Misc.

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, joepeck, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
The patch.	timothy: review+

Mark Lam

Reported 2013-09-20 12:52:18 PDT

This WebKit/mac WebScriptDebugger code is no longer needed. Patch to delete it coming soon.

Attachments
The patch. (20.85 KB, patch) 2013-09-21 18:43 PDT, Mark Lam	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2013-09-21 18:43:27 PDT

Created attachment 212291 [details] The patch. WebScriptDebugDelegate's didEnterCallFrame, willExecuteStatement, and willLeaveCallFrame are not in use. Removed them and all methods and fields used for supporting them.

Timothy Hatcher

Comment 2 2013-09-21 22:45:44 PDT

Comment on attachment 212291 [details] The patch. View in context: https://bugs.webkit.org/attachment.cgi?id=212291&action=review > Source/WebKit/mac/WebView/WebScriptDebugger.mm:129 > + RetainPtr<WebScriptCallFrame> callFrame; > + callFrame = adoptNS([[WebScriptCallFrame alloc] _initWithGlobalObject:core(webFrame)->script().windowScriptObject() debuggerCallFrame:debuggerCallFrame]); One line.

Mark Lam

Comment 3 2013-09-22 00:34:24 PDT

Thanks for the review. The one liner has been fixed. Landed in r156245: <http://trac.webkit.org/r156245>.

Note You need to log in before you can comment on or make changes to this bug.