Bug 121683

Summary: Fix a couple more CSS leaks
Product: WebKit Reporter: Darin Adler <darin>
Component: CSSAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, eflews.bot, esprehn+autocc, fpizlo, glenn, gyuyoung.kim, kling, koivisto, macpherson, menard, rego+ews, simon.fraser, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Darin Adler 2013-09-20 07:53:09 PDT 
Fix a couple more CSS leaks
Comment 1 Darin Adler 2013-09-20 07:54:58 PDT 
Created attachment 212165 [details]
Patch
Comment 2 EFL EWS Bot 2013-09-20 07:59:26 PDT 
Comment on attachment 212165 [details]
Patch

Attachment 212165 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/2019104
Comment 3 EFL EWS Bot 2013-09-20 07:59:48 PDT 
Comment on attachment 212165 [details]
Patch

Attachment 212165 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1865171
Comment 4 Early Warning System Bot 2013-09-20 08:00:16 PDT 
Comment on attachment 212165 [details]
Patch

Attachment 212165 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2018098
Comment 5 Early Warning System Bot 2013-09-20 08:00:31 PDT 
Comment on attachment 212165 [details]
Patch

Attachment 212165 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1811294
Comment 6 Darin Adler 2013-09-20 08:04:26 PDT 
Created attachment 212166 [details]
Patch
Comment 7 Alexey Proskuryakov 2013-09-20 08:47:42 PDT 
Comment on attachment 212166 [details]
Patch

EWS starts to think no:


Unexpected flakiness: timeouts (2)
  fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog.xml [ Crash Timeout Pass ]
  svg/hixie/error/dumpAsText/004.xml [ Crash Timeout Pass ]


Regressions: Unexpected crashes (18)
  fast/encoding/dumpAsText/utf-16-no-bom.xml [ Crash ]
  fast/frames/viewsource-attribute.html [ Crash ]
  fast/frames/viewsource-empty-attribute-value.html [ Crash ]
  fast/frames/viewsource-linebreak.html [ Crash ]
  fast/frames/viewsource-link-on-href-value.html [ Crash ]
  fast/frames/viewsource-on-image-file.html [ Crash ]
  fast/frames/viewsource-plain-text-tags.html [ Crash ]
  fast/frames/viewsource-unfinished-tags.html [ Crash ]
  fast/frames/viewsource-xml.html [ Crash ]
  http/tests/security/view-source-no-javascript-url.html [ Crash ]
  http/tests/security/view-source-no-refresh.html [ Crash ]
  http/tests/xmlviewer/dumpAsText/existing-tree-element-crash.xml [ Crash ]
  http/tests/xmlviewer/dumpAsText/xlink.xml [ Crash ]
  http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml [ Crash ]
  http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml [ Crash ]
  http/tests/xmlviewer/dumpAsText/xmlviewer.xml [ Crash ]
  http/tests/xmlviewer/dumpAsText/xul.xml [ Crash ]
  svg/hixie/error/dumpAsText/005.xml [ Crash ]
Comment 8 Darin Adler 2013-09-20 09:09:12 PDT 
Checking into the crashes now.
Comment 9 Darin Adler 2013-09-20 09:13:57 PDT 
Created attachment 212179 [details]
Patch
Comment 10 Darin Adler 2013-09-20 09:14:26 PDT 
I uploaded this new patch while I am testing it locally to give the bots a chance to get a crack at it too.
Comment 11 Alexey Proskuryakov 2013-09-20 10:10:58 PDT 
Comment on attachment 212179 [details]
Patch

EWS is happy, and so am I.
Comment 12 WebKit Commit Bot 2013-09-20 10:17:08 PDT 
Comment on attachment 212179 [details]
Patch

Clearing flags on attachment: 212179

Committed r156178: <http://trac.webkit.org/changeset/156178>
Comment 13 WebKit Commit Bot 2013-09-20 10:17:12 PDT 
All reviewed patches have been landed.  Closing bug.