Summary: | Add valueForLength/minimumValueForLength wrappers to RenderObject. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | Layout and Rendering | Assignee: | Andreas Kling <kling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andreas Kling
2013-09-20 06:29:37 PDT
Created attachment 212157 [details]
Patch idea
Comment on attachment 212157 [details] Patch idea View in context: https://bugs.webkit.org/attachment.cgi?id=212157&action=review > Source/WebCore/rendering/RenderObject.h:1003 > + LayoutUnit valueForLength(const Length& length, LayoutUnit maximumValue, bool roundPercentages = false) const > + { > + return WebCore::valueForLength(length, maximumValue, &view(), roundPercentages); > + } > + > + LayoutUnit minimumValueForLength(const Length& length, LayoutUnit maximumValue, bool roundPercentages = false) const > + { > + return WebCore::minimumValueForLength(length, maximumValue, &view(), roundPercentages); > + } RenderText should not have any valid uses for these. Please move to RenderElement. Created attachment 212168 [details]
Land
Comment on attachment 212168 [details] Land Clearing flags on attachment: 212168 Committed r156166: <http://trac.webkit.org/changeset/156166> All reviewed patches have been landed. Closing bug. |