Bug 121672

Summary: [CMake] Use COMPILE_DEFINITIONS target property for setting BUILDING_* defines
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2013-09-20 04:34:22 PDT
[CMake] Use COMPILE_DEFINITIONS target property for setting BUILDING_* defines
Attachments
Patch (5.85 KB, patch)
2013-09-20 04:41 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2013-09-20 04:41:45 PDT
Created attachment 212149 [details] Patch
Gyuyoung Kim
Comment 2 2013-09-20 05:55:48 PDT
Comment on attachment 212149 [details] Patch Looks make sense.
WebKit Commit Bot
Comment 3 2013-09-20 06:22:20 PDT
Comment on attachment 212149 [details] Patch Clearing flags on attachment: 212149 Committed r156159: <http://trac.webkit.org/changeset/156159>
WebKit Commit Bot
Comment 4 2013-09-20 06:22:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.