Bug 121671

Summary: Make RenderObject::parent() return RenderElement
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
webkit-ews: commit-queue-
another kling: review+

Antti Koivisto
Reported 2013-09-20 03:44:28 PDT
It always is.
Attachments
patch (42.78 KB, patch)
2013-09-20 03:55 PDT, Antti Koivisto 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
another (43.40 KB, patch)
2013-09-20 04:29 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-09-20 03:55:30 PDT
Created attachment 212147 [details] patch
Early Warning System Bot
Comment 2 2013-09-20 04:02:57 PDT
Comment on attachment 212147 [details] patch Attachment 212147 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1820199
Early Warning System Bot
Comment 3 2013-09-20 04:04:36 PDT
Comment on attachment 212147 [details] patch Attachment 212147 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1865109
Andreas Kling
Comment 4 2013-09-20 04:13:10 PDT
Comment on attachment 212147 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=212147&action=review > Source/WebCore/rendering/RenderBlock.cpp:1791 > + RenderBlock* nextSiblingBlock = toRenderBlock(curr); Why not make it a RenderBlock& > Source/WebCore/rendering/RenderElement.cpp:142 > + RenderObjectChildList* children = this->children(); > + ASSERT(children); > + if (!children) > + return; Wish 'children' would be a RenderObjectChildList& after the null check. > Source/WebCore/rendering/RenderElement.cpp:196 > + RenderObjectChildList* children = this->children(); > + ASSERT(children); > + if (!children) > + return; Ditto.
Antti Koivisto
Comment 5 2013-09-20 04:29:35 PDT
Created attachment 212148 [details] another
Andreas Kling
Comment 6 2013-09-20 04:35:28 PDT
Comment on attachment 212148 [details] another r=me
Antti Koivisto
Comment 7 2013-09-20 05:28:59 PDT
http://trac.webkit.org/changeset/156151
Note You need to log in before you can comment on or make changes to this bug.