Bug 121647

Summary:

Modernize Length setters/getters

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, dstockwell, esprehn+autocc, glenn, kondapallykalyan, macpherson, menard, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Anders Carlsson

Reported 2013-09-19 17:13:52 PDT

Modernize Length setters/getters

Attachments
Patch (84.15 KB, patch) 2013-09-19 17:27 PDT, Anders Carlsson	kling: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2013-09-19 17:27:27 PDT

Created attachment 212109 [details] Patch

WebKit Commit Bot

Comment 2 2013-09-19 17:28:58 PDT

Attachment 212109 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/CalculationValue.h', u'Source/WebCore/platform/Length.cpp', u'Source/WebCore/platform/Length.h', u'Source/WebCore/platform/LengthBox.cpp', u'Source/WebCore/platform/LengthBox.h', u'Source/WebCore/platform/LengthSize.h', u'Source/WebCore/platform/graphics/filters/FilterOperation.h', u'Source/WebCore/rendering/style/BasicShapes.h', u'Source/WebCore/rendering/style/FillLayer.h', u'Source/WebCore/rendering/style/NinePieceImage.cpp', u'Source/WebCore/rendering/style/NinePieceImage.h', u'Source/WebCore/rendering/style/RenderStyle.cpp', u'Source/WebCore/rendering/style/RenderStyle.h', u'Source/WebCore/rendering/style/StyleBoxData.h', u'Source/WebCore/rendering/style/StyleReflection.h']" exit_code: 1 Source/WebCore/platform/Length.cpp:181: Missing spaces around >> [whitespace/operators] [3] Source/WebCore/platform/Length.cpp:193: Missing spaces around >> [whitespace/operators] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:500: This { should be at the end of the previous line [whitespace/braces] [4] Source/WebCore/css/DeprecatedStyleBuilder.cpp:515: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 3 2013-09-19 17:35:02 PDT

Comment on attachment 212109 [details] Patch Delicious C++11! r=me assuming tests still pass.

Anders Carlsson

Comment 4 2013-09-19 17:59:22 PDT

Committed r156132: <http://trac.webkit.org/changeset/156132>

Note You need to log in before you can comment on or make changes to this bug.