Bug 121613

Summary: [GTK] Fix some small style issues in the bindings
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, cdumez, cgarcia, commit-queue, eric.carlson, glenn, gustavo, jer.noble, jsbell
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Martin Robinson
Reported 2013-09-19 09:45:24 PDT
Nothing really important, just a little bit of cleanup for the output.
Attachments
Patch (272.63 KB, patch)
2013-09-19 11:36 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2013-09-19 11:36:24 PDT
Created attachment 212086 [details] Patch
Carlos Garcia Campos
Comment 2 2013-09-19 23:37:34 PDT
Comment on attachment 212086 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212086&action=review Excellent! > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:556 > + my %parameterSpecOptions = ("int" => [ "G_MININT", "G_MAXINT", "0" ], > + "int8" => [ "G_MININT8", "G_MAXINT8", "0" ], > + "boolean" => [ "FALSE" ], > + "float" => [ "-G_MAXFLOAT", "G_MAXFLOAT", "0" ], > + "double" => [ "-G_MAXDOUBLE", "G_MAXDOUBLE", "0" ], > + "uint64" => [ "0", "G_MAXUINT64", "0" ], > + "long" => [ "G_MINLONG", "G_MAXLONG", "0" ], > + "int64" => [ "G_MININT64", "G_MAXINT64", "0" ], > + "ulong" => [ "0", "G_MAXULONG", "0" ], > + "uint" => [ "0", "G_MAXUINT", "0" ], > + "uint8" => [ "0", "G_MAXUINT8", "0" ], > + "ushort" => [ "0", "G_MAXUINT16", "0" ], > + "uchar" => [ "G_MININT8", "G_MAXINT8", "0" ], > + "char" => [ "0", "G_MAXUINT8", "0" ], > + "string" => [ '""', ], > + "object" => [ "WEBKIT_TYPE_DOM_${ucPropGType}" ]); > + :-)
Martin Robinson
Comment 3 2013-09-20 08:07:49 PDT
Comment on attachment 212086 [details] Patch Clearing flags on attachment: 212086 Committed r156163: <http://trac.webkit.org/changeset/156163>
Martin Robinson
Comment 4 2013-09-20 08:07:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.