Bug 121565

Summary:	AX: Notification tests shouldn't call waitUntilDone/notifyDone explicitly.
Product:	WebKit	Reporter:	Samuel White <samuel_white>
Component:	Accessibility	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	528+ (Nightly build)
Hardware:	All
OS:	All

Description Samuel White 2013-09-18 12:58:09 PDT

The following accessibility notification related tests are mixing explicit calls to waitUntilDone()/notifyDone() and setting window.jsTestIsAsync to true and calling finishJSTest(). Including the pre and post headers and setting window.jsTestIsAsync to true and calling finishJSTest is all that is actually needed as this will lead to waitUntilDone/notifyDone being called. We should clean these tests up so they are easier to follow and so others don't follow this incorrect mix and match pattern in the future.

LayoutTests/accessibility/aria-checkbox-sends-notification.html
LayoutTests/accessibility/aria-invalid.html
LayoutTests/accessibility/loading-iframe-sends-notification.html
LayoutTests/accessibility/menu-list-sends-change-notification.html
LayoutTests/accessibility/multiselect-list-reports-active-option.html
LayoutTests/accessibility/notification-listeners.html
LayoutTests/platform/iphone-simulator/accessibility/focus-change-notifications.html
LayoutTests/platform/mac/accessibility/aria-expanded-notifications.html
LayoutTests/platform/mac/accessibility/aria-listbox-selectedchildren-change.html
LayoutTests/platform/mac/accessibility/aria-liveregion-on-image.html
LayoutTests/platform/mac/accessibility/aria-liveregions-addedelement.html
LayoutTests/platform/mac/accessibility/aria-liveregions-changedalt.html
LayoutTests/platform/mac/accessibility/aria-liveregions-changedtext.html
LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent.html
LayoutTests/platform/mac/accessibility/aria-liveregions-notifications.html
LayoutTests/platform/mac/accessibility/aria-liveregions-removedelement.html
LayoutTests/platform/mac/accessibility/change-notification-on-scroll.html
LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications.html
LayoutTests/platform/mac/accessibility/html-slider-indicator.html
LayoutTests/platform/mac/accessibility/selected-rows-table.html
LayoutTests/platform/mac/accessibility/selection-value-changes-for-aria-textbox.html
LayoutTests/platform/mac/accessibility/textbox-role-reports-notifications.html

Comment 1 Radar WebKit Bug Importer 2013-09-18 12:58:40 PDT

<rdar://problem/15023298>