Bug 121563

Summary: SharedWorkerProcess code is dead
Product: WebKit Reporter: David Farler <dfarler>
Component: WebKit2Assignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ddkilzer, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

David Farler
Reported 2013-09-18 12:02:41 PDT
It looks like SharedWorkerProcess-related code is dead. In addition, it calls unimplemented functions, which result in linker errors with trunk clang. Ld /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/WebKit2.framework/Versions/A/WebKit2 normal x86_64 cd /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/Source/WebKit2 /Volumes/Data/BuildSlave/build-asan-webkit/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/clang++ -arch x86_64 -dynamiclib -L/Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug -F/Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug -F/Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug -F/System/Library/Frameworks/ApplicationServices.framework/Frameworks -F/System/Library/Frameworks/Carbon.framework/Frameworks -F/System/Library/Frameworks/Quartz.framework/Frameworks -F/System/Library/Frameworks/CoreServices.framework/Frameworks -filelist /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/WebKit2.build/Debug/WebKit2.build/Objects-normal/x86_64/WebKit2.LinkFileList -Xlinker --no-demangle -install_name /System/Library/PrivateFrameworks/WebKit2.framework/Versions/A/WebKit2 -mmacosx-version-min=10.9 -v -Xlinker -why_live -Xlinker __ZN6WebKit24SharedWorkerProcessProxy37platformInitializeSharedWorkerProcessERNS_37SharedWorkerProcessCreationParametersE -fsanitize=address -lclang_rt.asan_osx_dynamic -Wl,-unexported_symbol -Wl,__ZTISt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTISt9exception -Wl,-unexported_symbol -Wl,__ZTSSt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTSSt9exception -Wl,-unexported_symbol -Wl,__ZdlPvS_ -Wl,-unexported_symbol -Wl,__ZnwmPv -Wl,-unexported_symbol -Wl,__Znwm -framework ApplicationServices -framework Carbon -framework Cocoa -framework CoreServices -framework IOKit -framework JavaScriptCore -licucore -framework QuartzCore -framework Security -framework WebCore -framework CoreAudio -lWebKitSystemInterfaceMountainLion -stdlib=libc++ -fobjc-link-runtime -single_module -compatibility_version 1 -current_version 538.1 -Xlinker -dependency_info -Xlinker /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/WebKit2.build/Debug/WebKit2.build/Objects-normal/x86_64/WebKit2_dependency_info.dat -o /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/WebKit2.framework/Versions/A/WebKit2 clang version 3.4 (trunk 190946) Target: x86_64-apple-darwin13.0.0 Thread model: posix "/Volumes/Data/BuildSlave/build-asan-webkit/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/ld" -dynamic -dylib -dylib_compatibility_version 1 -dylib_current_version 538.1 -arch x86_64 -dylib_install_name /System/Library/PrivateFrameworks/WebKit2.framework/Versions/A/WebKit2 -macosx_version_min 10.9.0 -single_module -o /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug/WebKit2.framework/Versions/A/WebKit2 -L/Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug -U ___asan_init_v3 -filelist /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/WebKit2.build/Debug/WebKit2.build/Objects-normal/x86_64/WebKit2.LinkFileList -why_live __ZN6WebKit24SharedWorkerProcessProxy37platformInitializeSharedWorkerProcessERNS_37SharedWorkerProcessCreationParametersE -lclang_rt.asan_osx_dynamic -unexported_symbol __ZTISt9bad_alloc -unexported_symbol __ZTISt9exception -unexported_symbol __ZTSSt9bad_alloc -unexported_symbol __ZTSSt9exception -unexported_symbol __ZdlPvS_ -unexported_symbol __ZnwmPv -unexported_symbol __Znwm -framework ApplicationServices -framework Carbon -framework Cocoa -framework CoreServices -framework IOKit -framework JavaScriptCore -licucore -framework QuartzCore -framework Security -framework WebCore -framework CoreAudio -lWebKitSystemInterfaceMountainLion -dependency_info /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/WebKit2.build/Debug/WebKit2.build/Objects-normal/x86_64/WebKit2_dependency_info.dat -framework Foundation -lobjc -lc++ -lSystem /Volumes/Data/BuildSlave/build-trunk-clang/build/Release+Asserts/bin/../lib/clang/3.4/lib/darwin/libclang_rt.osx.a -F/Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug -F/Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Debug -F/System/Library/Frameworks/ApplicationServices.framework/Frameworks -F/System/Library/Frameworks/Carbon.framework/Frameworks -F/System/Library/Frameworks/Quartz.framework/Frameworks -F/System/Library/Frameworks/CoreServices.framework/Frameworks Undefined symbols for architecture x86_64: "__ZN6WebKit24SharedWorkerProcessProxy37platformInitializeSharedWorkerProcessERNS_37SharedWorkerProcessCreationParametersE", referenced from: __ZN6WebKit24SharedWorkerProcessProxy18didFinishLaunchingEPNS_15ProcessLauncherEN7CoreIPC10Connection10IdentifierE in SharedWorkerProcessProxy.o "__ZN6WebKit8Download13useCredentialERKN7WebCore23AuthenticationChallengeERKNS1_10CredentialE", referenced from: __ZN6WebKit28DownloadAuthenticationClient18receivedCredentialERKN7WebCore23AuthenticationChallengeERKNS1_10CredentialE in DownloadAuthenticationClient.o "__ZN6WebKit8Download25continueWithoutCredentialERKN7WebCore23AuthenticationChallengeE", referenced from: __ZN6WebKit28DownloadAuthenticationClient42receivedRequestToContinueWithoutCredentialERKN7WebCore23AuthenticationChallengeE in DownloadAuthenticationClient.o "__ZN6WebKit8Download29cancelAuthenticationChallengeERKN7WebCore23AuthenticationChallengeE", referenced from: __ZN6WebKit28DownloadAuthenticationClient20receivedCancellationERKN7WebCore23AuthenticationChallengeE in DownloadAuthenticationClient.o "__ZN7WebCore15ContextMenuItemC1ENS_17ContextMenuActionERKN3WTF6StringEbbRNS2_6VectorIS0_Lm0ENS2_15CrashOnOverflowEEE", referenced from: __ZNK6WebKit22WebContextMenuItemData4coreEv in WebContextMenuItemData.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation)
Attachments
Patch (127.67 KB, patch)
2013-09-23 10:35 PDT, Sam Weinig 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-09-18 13:20:32 PDT
I'll fix this.
David Farler
Comment 2 2013-09-19 10:50:16 PDT
Looks like DownloadAuthenticationClient can be axed too, I just realized that it’s included in the linker errors below. Do you want to kill it in this bug as well? If so, https://bugs.webkit.org/show_bug.cgi?id=119667 can be duped to this.
Sam Weinig
Comment 3 2013-09-23 10:35:37 PDT
Created attachment 212363 [details] Patch
Alexey Proskuryakov
Comment 4 2013-09-23 10:36:05 PDT
Comment on attachment 212363 [details] Patch rs=me
Sam Weinig
Comment 5 2013-09-23 10:38:37 PDT
Committed r156277: <http://trac.webkit.org/changeset/156277>
David Farler
Comment 6 2013-11-18 11:45:24 PST
*** Bug 119668 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.