Bug 121550 – Avoid using RenderBR internally in RenderMenuList.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Andreas Kling]

Avoid using RenderBR internally in RenderMenuList.

[Andreas Kling]

Created attachment 211987 [details]
Patch

[Andreas Kling]

Created attachment 211988 [details]
Patch

[Build Bot]

Comment on attachment 211988 [details]
Patch

Attachment 211988 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1886432

New failing tests:
fast/forms/menulist-separator-painting.html
fast/forms/select-empty-option-height.html
fast/forms/select-baseline.html
fast/replaced/three-selects-break.html
fast/forms/form-element-geometry.html
fast/flexbox/clear-overflow-before-scroll-update.html
fast/forms/HTMLOptionElement_label06.html
fast/forms/selectlist-minsize.html
fast/forms/HTMLOptionElement_label07.html

[Build Bot]

Created attachment 211989 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 211988 [details]
Patch

Attachment 211988 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1930152

New failing tests:
fast/forms/menulist-separator-painting.html
fast/forms/select-empty-option-height.html
fast/forms/select-baseline.html
fast/replaced/three-selects-break.html
fast/forms/form-element-geometry.html
fast/flexbox/clear-overflow-before-scroll-update.html
fast/forms/HTMLOptionElement_label06.html
fast/forms/selectlist-minsize.html
fast/forms/HTMLOptionElement_label07.html

[Build Bot]

Created attachment 211993 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Andreas Kling]

Created attachment 211995 [details]
Patch

[Antti Koivisto]

Comment on attachment 211995 [details]
Patch

r=me

[Antti Koivisto]

Comment on attachment 211995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211995&action=review

> Source/WebCore/rendering/RenderMenuList.cpp:245
> +        m_buttonText = new (renderArena()) RenderText(&document(), s.impl());

we need RenderText::createAnonymous

[Build Bot]

Comment on attachment 211995 [details]
Patch

Attachment 211995 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1889231

New failing tests:
fast/forms/menulist-separator-painting.html
fast/forms/select-empty-option-height.html
fast/forms/select-baseline.html
fast/replaced/three-selects-break.html
fast/forms/form-element-geometry.html
fast/flexbox/clear-overflow-before-scroll-update.html
fast/forms/HTMLOptionElement_label06.html
fast/forms/selectlist-minsize.html
fast/forms/HTMLOptionElement_label07.html
platform/mac/editing/input/caret-primary-bidi.html

[Build Bot]

Created attachment 211998 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Andreas Kling]

Committed r156040: <http://trac.webkit.org/changeset/156040>

[Darin Adler]

Why a newline? If the text can be set to something arbitrary, say a space, then why not use a space?

[Andreas Kling]

(In reply to comment #13)
> Why a newline? If the text can be set to something arbitrary, say a space, then why not use a space?

I don't know really. Looks like whitespace collapsing turns it into a space in the end anyway..

Does it make a difference somehow? If so I can fix it :)

[Darin Adler]

(In reply to comment #14)
> Does it make a difference somehow?

I have no idea.