Bug 121498

Summary:

Make SVGTransform::valueAsString use StringBuilder

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

SVG

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, d-r, fmalita, pdr, schenney, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	kling: review+

Darin Adler

Reported 2013-09-17 09:41:06 PDT

Make SVGTransform::valueAsString use StringBuilder

Attachments
Patch (7.10 KB, patch) 2013-09-17 09:43 PDT, Darin Adler	kling: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2013-09-17 09:43:15 PDT

Created attachment 211915 [details] Patch

Darin Adler

Comment 2 2013-09-17 10:08:14 PDT

Committed r155968: <http://trac.webkit.org/changeset/155968>

Alexey Proskuryakov

Comment 3 2013-09-17 12:06:50 PDT

This broke a regression test, fixed in <http://trac.webkit.org/r155982>. Mac EWS was doing a pretty good job on this, it had failing results soon after the patch landed.

Darin Adler

Comment 4 2013-09-18 18:28:33 PDT

Thanks Alexey. Really sorry I didn’t notice it on EWS.

Note You need to log in before you can comment on or make changes to this bug.