Bug 121495

Summary:

[ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix

Product:

WebKit

Reporter:

Mario Sanchez Prada <mario>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jdiggs, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch proposal	cfleizach: review+

Mario Sanchez Prada

Reported 2013-09-17 08:45:27 PDT

According to the WAI-ARIA implementation spec, the 'aria-haspopup' and 'aria-sort' attributes should be exposed as ATK object attributes named 'haspopup' and 'sort', without the 'aria-' prefix. http://www.w3.org/TR/wai-aria-implementation/

Attachments
Patch proposal (48.15 KB, patch) 2013-09-17 08:57 PDT, Mario Sanchez Prada	cfleizach: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2013-09-17 08:45:50 PDT

<rdar://problem/15009403>

Mario Sanchez Prada

Comment 2 2013-09-17 08:57:08 PDT

Created attachment 211912 [details] Patch proposal This should be straightforward, I hope, since it's just one small change in the ATK wrapper + small changes in DRT/WKTR + pure rebaselining.

chris fleizach

Comment 3 2013-09-17 10:21:01 PDT

Comment on attachment 211912 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=211912&action=review > Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:909 > + // We need to translate ATK values exposed for 'aria-sort' (e.g. 'asdending') asdending > ascending > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:572 > + // We need to translate ATK values exposed for 'aria-sort' (e.g. 'asdending') ditto

Mario Sanchez Prada

Comment 4 2013-09-18 01:28:00 PDT

Committed r156033: <http://trac.webkit.org/changeset/156033>

Note You need to log in before you can comment on or make changes to this bug.