Bug 12149

Summary: REGRESSION (r18175): External CSS causes incomplete text field focus
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, dev+webkit, ggaren
Priority: P1 Keywords: HasReduction, InRadar, Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: https://login.yahoo.com/
Attachments:
Description Flags
Reduction none

David Kilzer (:ddkilzer)
Reported 2007-01-07 05:20:23 PST
Summary: When loading the Yahoo! login page, the username field ("Yahoo! ID:") will get a focus ring drawn, but the text field will not get focus (no caret drawn, and characters do not appear in the field when typing). Steps to reproduce: 1. Open WebKit nightly. 2. Open URL: https://login.yahoo.com/ Expected results: The username ("Yahoo! ID:") field should get full focus (focus ring, caret, typing enters characters into the field). Actual results: The username ("Yahoo! ID:") field gets a focus ring, but not a caret and typing does not enter characters into the field. Regression: This is a regression from shipping Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8N1037). Tested with a locally-built debug build of WebKit r18649. Notes: Approximately 1 in 10 times after loading the page, the username ("Yahoo! ID:") field WILL get full focus. The rest of the time this bug is seen.
Attachments
Reduction (309 bytes, text/html)
2007-01-07 11:46 PST, Matt Lilek 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2007-01-07 05:24:18 PST
(In reply to comment #0) > Notes: > > Approximately 1 in 10 times after loading the page, the username ("Yahoo! ID:") > field WILL get full focus. The rest of the time this bug is seen. More accurately, it appears that the username field gets full focus the first time the page is loaded in a new window or a new tab, but on all subsequent reloads, the username field only gets a focus ring.
Matt Lilek
Comment 2 2007-01-07 10:04:25 PST
I've seen this on Facebook's login page also.
Matt Lilek
Comment 3 2007-01-07 11:44:25 PST
The issue seems to be with linked CSS and inline Javascript. If a page links to an external CSS file, then calls focus on a form from within the <body>, it gets focus but no caret. The external CSS file doesn't need to exist or even be specified for this to happen - just so long as <link rel="stylesheet"> or <style>@import "";</style> is there. The focus also needs to be called from within the body, not from an event handler. I've also verified that this is the same issue on Facebook.
Matt Lilek
Comment 4 2007-01-07 11:46:25 PST
Created attachment 12281 [details] Reduction The interesting thing about this reduction is that while the input gets focus from the script, when you click the "focused" input, it gets focused again.
David Kilzer (:ddkilzer)
Comment 5 2007-01-07 16:51:42 PST
Doing a binary search of WebKit nightly builds, the regression occurred between r18159 (works as expected) and r18187 (fails).
David Kilzer (:ddkilzer)
Comment 6 2007-01-07 17:04:20 PST
(In reply to comment #5) > Doing a binary search of WebKit nightly builds, the regression occurred between > r18159 (works as expected) and r18187 (fails). Suspicious revisions include r18175 and r18187. http://trac.webkit.org/projects/webkit/changeset/18175 http://trac.webkit.org/projects/webkit/changeset/18187
David Kilzer (:ddkilzer)
Comment 7 2007-01-07 18:02:26 PST
Rebuilding locally, confirmed that r18175 caused the regression.
Darin Adler
Comment 8 2007-01-11 09:13:00 PST
Another way to describe this is: "calling focus() on a text field that has no renderer causes incomplete text field focus".
Mark Rowe (bdash)
Comment 9 2007-01-16 19:45:15 PST
<rdar://problem/4928692>
Dave Hyatt
Comment 10 2007-02-12 21:43:19 PST
Fixed.
David Kilzer (:ddkilzer)
Comment 11 2007-02-13 03:30:27 PST
r19595
Note You need to log in before you can comment on or make changes to this bug.