Bug 121483

Summary: Use shouldBecomeEqual in asynchronous spellchecking tests
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: Tools / TestsAssignee: Grzegorz Czajkowski <g.czajkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, commit-queue, darin, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Grzegorz Czajkowski
Reported 2013-09-17 05:06:47 PDT
Every asynchronous spellchecking layout test waits for spelling or grammar markers to appear using setTimeout. It duplicates the code, moreover the implementation differs in every test. This change proposes to use shouldBecomeEqual helper (introduced in r143860) to test spellchecking asynchronously.
Attachments
Patch (247.89 KB, patch)
2013-09-17 05:26 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2013-09-17 05:26:06 PDT
Created attachment 211891 [details] Patch
WebKit Commit Bot
Comment 2 2013-09-19 21:06:10 PDT
Comment on attachment 211891 [details] Patch Clearing flags on attachment: 211891 Committed r156137: <http://trac.webkit.org/changeset/156137>
WebKit Commit Bot
Comment 3 2013-09-19 21:06:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.