Bug 121463

Summary: [Windows] Provide a short history in WinLauncher to make testing easier
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Enhancement CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Brent Fulgham
Reported 2013-09-16 17:39:54 PDT
I am constantly pasting (or worse, TYPING) various URL's into WinLauncher to try things out. Life would be much better with a short 'history' that would allow quick cycling between some test pages. This patch updates WinLauncher with a rudimentary history feature to help with this. Note: This code is getting very ugly due to lack of smart pointers. I intend to introduce a patch that uses the WTF types to reduce the amount of goto's and manual cleanup code.d
Attachments
Patch (12.00 KB, patch)
2013-09-16 17:47 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (12.21 KB, patch)
2013-09-16 18:08 PDT, Brent Fulgham 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-09-16 17:47:58 PDT
Created attachment 211847 [details] Patch
Radar WebKit Bug Importer
Comment 2 2013-09-16 17:49:38 PDT
<rdar://problem/15005230>
Anders Carlsson
Comment 3 2013-09-16 17:51:37 PDT
Comment on attachment 211847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211847&action=review > Tools/WinLauncher/WinLauncher.cpp:220 > + No need for this newline. > Tools/WinLauncher/WinLauncher.cpp:229 > + IWebBackForwardList* backForwardList = 0; > + IWebHistoryItem* currentItem = 0; > + IWebHistoryPrivate* webHistory = 0; I think you should use COMPtr for these or at least _com_ptr_t.
Brent Fulgham
Comment 4 2013-09-16 18:08:17 PDT
Created attachment 211850 [details] Patch
Brent Fulgham
Comment 5 2013-09-16 18:26:37 PDT
Committed r155922: <http://trac.webkit.org/changeset/155922>
Note You need to log in before you can comment on or make changes to this bug.