Bug 121421

Summary: CSS Unit vmax and vmin in border-width not handled.
Product: WebKit Reporter: gur.trio
Component: CSSAssignee: gur.trio
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, darin, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard, philn, rniwa, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
test case with border-width in vmax
none
Patch
none
Patch none

Description gur.trio 2013-09-16 03:48:04 PDT 
The border-width if in terms of vmax or vmin is not being applied.
Comment 1 gur.trio 2013-09-16 03:49:08 PDT 
Created attachment 211755 [details]
test case with border-width in vmax
Comment 2 gur.trio 2013-09-16 21:21:55 PDT 
Created attachment 211862 [details]
Patch
Comment 3 Early Warning System Bot 2013-09-16 21:29:48 PDT 
Comment on attachment 211862 [details]
Patch

Attachment 211862 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1869270
Comment 4 EFL EWS Bot 2013-09-16 21:40:59 PDT 
Comment on attachment 211862 [details]
Patch

Attachment 211862 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1869269
Comment 5 Build Bot 2013-09-16 21:47:57 PDT 
Comment on attachment 211862 [details]
Patch

Attachment 211862 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1804994
Comment 6 Build Bot 2013-09-16 22:01:18 PDT 
Comment on attachment 211862 [details]
Patch

Attachment 211862 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1850239
Comment 7 gur.trio 2013-09-16 22:03:08 PDT 
Created attachment 211863 [details]
Patch
Comment 8 gur.trio 2013-09-17 05:36:14 PDT 
(In reply to comment #7)
> Created an attachment (id=211863) [details]
> Patch

Hi Darin. Any more changes required?
Comment 9 gur.trio 2013-09-18 20:13:18 PDT 
(In reply to comment #8)
> (In reply to comment #7)
> > Created an attachment (id=211863) [details] [details]
> > Patch
> 
> Hi Darin. Any more changes required?

Hi Darin. Could you please set the commit-queue+ flag incase no more changes are required.
Comment 10 WebKit Commit Bot 2013-09-19 04:02:29 PDT 
Comment on attachment 211863 [details]
Patch

Clearing flags on attachment: 211863

Committed r156091: <http://trac.webkit.org/changeset/156091>
Comment 11 WebKit Commit Bot 2013-09-19 04:02:33 PDT 
All reviewed patches have been landed.  Closing bug.