Bug 121417

Summary: Buildfix for !ENABLE(CUSTOM_PROTOCOLS) platforms
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, ap, beidson, cdumez, cmarcelo, commit-queue, darin, gyuyoung.kim, gyuyoung.kim, kbalazs, menard, ossy, philn, rakuco, skyul, webkit-ews, xan.lopez, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 110141    
Attachments:
Description Flags
Patch
none
alternative fix
none
alternative fix
none
alternative fix none

Description Csaba Osztrogonác 2013-09-16 03:05:31 PDT 
SSIA
Comment 1 Csaba Osztrogonác 2013-09-16 03:09:13 PDT 
Created attachment 211749 [details]
Patch
Comment 2 Csaba Osztrogonác 2013-09-16 03:28:13 PDT 
(In reply to comment #1)
> Created an attachment (id=211749) [details]
> Patch

The previous discussion about it:
https://bugs.webkit.org/show_bug.cgi?id=110141#c25

> There are 2 possible fix for it:
> - including CustomProtocolManagerProxyMessages.h conditionally
> - adding CustomProtocolManagerProxy.messages.in to the cmake build system to generate the useless CustomProtocolManagerProxyMessages.h
Comment 3 Csaba Osztrogonác 2013-09-16 03:36:37 PDT 
Created attachment 211754 [details]
alternative fix

alternative fix, I haven't tested it yet
Comment 4 Early Warning System Bot 2013-09-16 03:43:11 PDT 
Comment on attachment 211754 [details]
alternative fix

Attachment 211754 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1810205
Comment 5 Csaba Osztrogonác 2013-09-16 03:58:51 PDT 
Created attachment 211758 [details]
alternative fix

with additional Qt and GTK buildfixes
Comment 6 Csaba Osztrogonác 2013-09-16 04:13:30 PDT 
Created attachment 211760 [details]
alternative fix

with one more GTK buildfix
Comment 7 Csaba Osztrogonác 2013-09-16 04:33:29 PDT 
Comment on attachment 211760 [details]
alternative fix

r? it too, and let the reviewer to decide which one is the better.
Comment 8 Csaba Osztrogonác 2013-09-16 06:13:42 PDT 
Comment on attachment 211749 [details]
Patch

I prefer the alternative way. It is a little bit longer,
but more general.
Comment 9 Csaba Osztrogonác 2013-09-17 12:59:05 PDT 
Comment on attachment 211760 [details]
alternative fix

Clearing flags on attachment: 211760

Committed r155987: <http://trac.webkit.org/changeset/155987>
Comment 10 Csaba Osztrogonác 2013-09-17 12:59:13 PDT 
All reviewed patches have been landed.  Closing bug.