Bug 121379

Summary:

Get rid of ref-counting on RenderArena.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kangil.han, kling, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Andreas Kling 2013-09-15 00:33:26 PDT

Get rid of ref-counting on RenderArena.

Comment 1 Andreas Kling 2013-09-15 00:34:34 PDT

Created attachment 211689 [details]
Patch

Comment 2 Darin Adler 2013-09-15 00:50:37 PDT

Comment on attachment 211689 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211689&action=review

> Source/WebCore/dom/Document.h:1380
> -    RefPtr<RenderArena> m_renderArena;
> +    OwnPtr<RenderArena> m_renderArena;

Maybe just RenderArena would be even better? Maybe not.

> Source/WebCore/rendering/RenderArena.h:46
> +class RenderArena {

Needs noncopyableness. Used to just inherit that from RefCounted.

Comment 3 Andreas Kling 2013-09-15 01:20:23 PDT

Committed r155800: <http://trac.webkit.org/changeset/155800>