Bug 121374

Summary:

Deoptimize deoptimization: make DFGOSRExitCompiler64.cpp more hackable

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, eflews.bot, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, sam, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

121064, 122025

Attachments:

Description	Flags
this is just the start	none
the patch	ggaren: review+, eflews.bot: commit-queue-
patch for landing	none

Filip Pizlo

Reported 2013-09-14 18:21:00 PDT

It used to be the case that OSR exits happened a lot, and we sometimes let them happen roughly in proportion to the number of times that a function completed successfully. This was a long time ago - before we had good reoptimization heuristics and before we got our act together in other ways. Now we don't OSR exit that much. More than ~100 exits means that we reoptimize. Hence while we want OSR exit to not be terribly slow and it still makes sense to emit JIT code for it, we don't really care if it makes great use of registers or anything like that. But right now the OSRExitCompiler is still soooper optimized, and that makes the code hard to hack. This makes adding new kinds of data formats, which the exit compiler must know about, rather difficult. For example I couldn't figure out a good way of adding Int48 recoveries without either copy-pasting code or just adding a lot of confusing code paths. So, the best thing to do is probably to rewrite the exit compiler to be a lot dumber. The plan is to make it first dump all state into a scratch buffer (even if it's already in the stack in the right place!) and then dump back from the scratch buffer into the stack while performing the recoveries. This will allow for example combining the code for reboxing an int that was in the stack in the right place, in the stack in the wrong place, or in a register - all of those cases will work the same now, which is pretty awesome.

Attachments
this is just the start (4.89 KB, patch) 2013-09-14 18:21 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (34.69 KB, patch) 2013-09-14 21:01 PDT, Filip Pizlo	ggaren: review+ eflews.bot: commit-queue-	Details Formatted Diff Diff
patch for landing (36.39 KB, patch) 2013-09-15 11:02 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.