Bug 121373

Summary: Use FINAL instead of virtualChildren trick in render tree classes
Product: WebKit Reporter: Darin Adler <darin>
Component: Layout and RenderingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, d-r, eflews.bot, eric.carlson, esprehn+autocc, fmalita, glenn, gtk-ews, gyuyoung.kim, jer.noble, kondapallykalyan, pdr, rego+ews, rniwa, schenney, WebkitBugTracker, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Darin Adler
Reported 2013-09-14 15:58:16 PDT
Use FINAL instead of virtualChildren trick in render tree classes
Attachments
Patch (38.74 KB, patch)
2013-09-14 21:19 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (37.92 KB, patch)
2013-09-15 01:01 PDT, Darin Adler 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-09-14 21:19:16 PDT
Created attachment 211682 [details] Patch
EFL EWS Bot
Comment 2 2013-09-14 21:26:56 PDT
Comment on attachment 211682 [details] Patch Attachment 211682 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1916218
EFL EWS Bot
Comment 3 2013-09-14 21:35:15 PDT
Comment on attachment 211682 [details] Patch Attachment 211682 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1916219
Build Bot
Comment 4 2013-09-14 21:46:35 PDT
Comment on attachment 211682 [details] Patch Attachment 211682 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1878542
kov's GTK+ EWS bot
Comment 5 2013-09-14 21:53:03 PDT
Comment on attachment 211682 [details] Patch Attachment 211682 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1801737
Build Bot
Comment 6 2013-09-14 22:01:53 PDT
Comment on attachment 211682 [details] Patch Attachment 211682 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1911528
Build Bot
Comment 7 2013-09-14 22:59:46 PDT
Comment on attachment 211682 [details] Patch Attachment 211682 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1834497
Darin Adler
Comment 8 2013-09-15 01:01:08 PDT
Created attachment 211692 [details] Patch
Andreas Kling
Comment 9 2013-09-15 01:20:47 PDT
Comment on attachment 211692 [details] Patch Delightful!
Darin Adler
Comment 10 2013-09-15 01:50:40 PDT
Committed r155802: <http://trac.webkit.org/changeset/155802>
Note You need to log in before you can comment on or make changes to this bug.