Bug 121371

Summary: It should be easy to add new nodes that do OSR forward rewiring in both DFG and FTL
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 121064    
Attachments:
Description Flags
the patch
none
the patch sam: review+

Filip Pizlo
Reported 2013-09-14 15:14:29 PDT
Patch forthcoming.
Attachments
the patch (12.91 KB, patch)
2013-09-14 15:53 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (14.00 KB, patch)
2013-09-14 16:39 PDT, Filip Pizlo 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-09-14 15:53:28 PDT
Created attachment 211672 [details] the patch
WebKit Commit Bot
Comment 2 2013-09-14 15:55:57 PDT
Attachment 211672 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/dfg/DFGMinifiedNode.h', u'Source/JavaScriptCore/dfg/DFGNodeType.h', u'Source/JavaScriptCore/dfg/DFGVariableEventStream.cpp', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp']" exit_code: 1 Source/JavaScriptCore/dfg/DFGNodeType.h:310: Missing space before ( in switch( [whitespace/parens] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2013-09-14 15:57:32 PDT
(In reply to comment #2) > Attachment 211672 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/dfg/DFGMinifiedNode.h', u'Source/JavaScriptCore/dfg/DFGNodeType.h', u'Source/JavaScriptCore/dfg/DFGVariableEventStream.cpp', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp']" exit_code: 1 > Source/JavaScriptCore/dfg/DFGNodeType.h:310: Missing space before ( in switch( [whitespace/parens] [5] Fixed. > Total errors found: 1 in 5 files > > > If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 4 2013-09-14 16:06:54 PDT
Comment on attachment 211672 [details] the patch I think I can do better.
Filip Pizlo
Comment 5 2013-09-14 16:39:05 PDT
Created attachment 211675 [details] the patch
Filip Pizlo
Comment 6 2013-09-14 17:56:56 PDT
Landed in http://trac.webkit.org/changeset/155793
Note You need to log in before you can comment on or make changes to this bug.