Bug 12136

Summary: REGRESSION: Counters-related leaks
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P1 Keywords: Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://build.webkit.org/results/post-commit-leaks-powerpc-mac-os-x/4215/DumpRenderTree-leaks.txt
Attachments:
Description Flags
Delete child counter nodes, don't just remove them from the node map mjs: review+

Description mitz 2007-01-06 00:43:31 PST
Many leaks like this:
	Call stack: [thread ffffffff]: | 0x0 | start | _start | main | dumpRenderTree | runTest | -[NSRunLoop runMode:beforeDate:] | CFRunLoopRunSpecific | __CFRunLoopRun | __CFRunLoopDoSources0 | _sendCallbacks | -[NSURLConnection(NSURLConnectionInternal) _sendCallbacks] | -[NSURLConnection(NSURLConnectionInternal) _sendDidFinishLoadingCallback] | -[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:] | WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*) | WebCore::MainResourceLoader::didFinishLoading() | WebCore::FrameLoader::finishedLoading() | WebCore::DocumentLoader::finishedLoading() | WebCore::FrameLoader::end() | WebCore::FrameLoader::endIfNotLoading() | WebCore::Document::finishParsing() | WebCore::HTMLTokenizer::finish() | WebCore::HTMLTokenizer::end() | WebCore::HTMLParser::finished() | WebCore::Document::finishedParsing() | WebCore::FrameLoader::finishedParsing() | WebCore::FrameLoader::checkCompleted() | WebCore::FrameLoader::checkEmitLoadEvent() | WebCore::Document::implicitClose() | WebCore::FrameView::layout(bool) | WebCore::RenderView::layout() | WebCore::RenderObject::recalcMinMaxWidths() | WebCore::RenderObject::recalcMinMaxWidths() | WebCore::RenderObject::recalcMinMaxWidths() | WebCore::RenderObject::recalcMinMaxWidths() | WebCore::RenderObject::recalcMinMaxWidths() | WebCore::RenderObject::recalcMinMaxWidths() | WebCore::RenderObject::recalcMinMaxWidths() | WebCore::RenderCounter::calcMinMaxWidth() | WebCore::RenderCounter::originalString() const | WebCore::counter(WebCore::RenderObject*, WebCore::AtomicString const&, bool) | operator new(unsigned long) | WTF::fastMalloc(unsigned long)
Comment 1 mitz 2007-01-06 03:27:23 PST
Created attachment 12255 [details]
Delete child counter nodes, don't just remove them from the node map
Comment 2 David Kilzer (:ddkilzer) 2007-01-06 04:22:40 PST
Committed revision 18639.