Bug 121354

Summary:

Shrink the function that builds the event listener attribute name map

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

DOM

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	kling: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none

Darin Adler

Reported 2013-09-14 01:07:47 PDT

Shrink the function that builds the event listener attribute name map

Attachments
Patch (14.29 KB, patch) 2013-09-14 01:09 PDT, Darin Adler	kling: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (293.73 KB, application/zip) 2013-09-14 01:59 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (288.33 KB, application/zip) 2013-09-14 03:16 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (293.13 KB, application/zip) 2013-09-14 04:19 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2013-09-14 01:09:09 PDT

Created attachment 211634 [details] Patch

Andreas Kling

Comment 2 2013-09-14 01:13:18 PDT

Comment on attachment 211634 [details] Patch Cool!

Build Bot

Comment 3 2013-09-14 01:59:57 PDT

Comment on attachment 211634 [details] Patch Attachment 211634 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1834221 New failing tests: fast/events/click-count.html fast/dom/inline-event-attributes-lookup-removed-form.html editing/selection/focus-crash.html accessibility/onclick-handlers.html fast/events/event-attribute.html fast/dom/inline-event-attributes-event-param-name.html fast/events/attribute-listener-extracted-from-frameless-doc-context.html accessibility/label-element-press.html editing/selection/undo-crash.html fast/forms/button-click-DOM.html editing/selection/click-after-nested-block.html fast/dom/inline-event-attributes-moved.html fast/block/float/float-in-float-hit-testing.html fast/events/attribute-listener-deletion-crash.html fast/dom/inline-event-attributes-lookup-removed.html fast/dom/Element/onclick-case.html fast/dom/inline-event-attributes-lookup.html fast/events/attribute-listener-cloned-from-frameless-doc-context.html fast/forms/access-key.html fast/dom/HTMLTableColElement/resize-table-using-col-width.html fast/dom/HTMLLabelElement/click-label.html fast/flexbox/line-clamp-link-after-ellipsis.html fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html fast/events/attribute-listener-cloned-from-frameless-doc.xhtml editing/selection/focus-and-display-none.html fast/forms/label/label-becomes-visible-while-clicking-on-label.html fast/forms/radio/radio-group-keyboard-change-event.html fast/forms/enter-clicks-buttons.html fast/dom/search-shadow-host-crash.html

Build Bot

Comment 4 2013-09-14 01:59:59 PDT

Created attachment 211635 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 5 2013-09-14 03:16:25 PDT

Comment on attachment 211634 [details] Patch Attachment 211634 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1801430 New failing tests: fast/events/click-count.html fast/dom/inline-event-attributes-lookup-removed-form.html editing/selection/focus-crash.html accessibility/onclick-handlers.html fast/events/event-attribute.html fast/dom/inline-event-attributes-event-param-name.html fast/events/attribute-listener-extracted-from-frameless-doc-context.html accessibility/label-element-press.html editing/selection/undo-crash.html fast/forms/button-click-DOM.html editing/selection/click-after-nested-block.html fast/dom/inline-event-attributes-moved.html fast/block/float/float-in-float-hit-testing.html fast/events/attribute-listener-deletion-crash.html fast/dom/inline-event-attributes-lookup-removed.html fast/dom/Element/onclick-case.html fast/dom/inline-event-attributes-lookup.html fast/events/attribute-listener-cloned-from-frameless-doc-context.html fast/forms/access-key.html fast/dom/HTMLTableColElement/resize-table-using-col-width.html fast/dom/HTMLLabelElement/click-label.html fast/flexbox/line-clamp-link-after-ellipsis.html fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html fast/events/attribute-listener-cloned-from-frameless-doc.xhtml editing/selection/focus-and-display-none.html fast/forms/label/label-becomes-visible-while-clicking-on-label.html fast/forms/radio/radio-group-keyboard-change-event.html fast/events/event-function-toString.html fast/dom/search-shadow-host-crash.html

Build Bot

Comment 6 2013-09-14 03:16:27 PDT

Created attachment 211639 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2013-09-14 04:19:51 PDT

Comment on attachment 211634 [details] Patch Attachment 211634 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1817347 New failing tests: fast/events/click-count.html fast/dom/inline-event-attributes-lookup-removed-form.html editing/selection/focus-crash.html accessibility/onclick-handlers.html fast/events/event-attribute.html fast/dom/inline-event-attributes-event-param-name.html fast/events/attribute-listener-extracted-from-frameless-doc-context.html accessibility/label-element-press.html editing/selection/undo-crash.html fast/forms/button-click-DOM.html editing/selection/click-after-nested-block.html fast/dom/inline-event-attributes-moved.html fast/block/float/float-in-float-hit-testing.html fast/events/attribute-listener-deletion-crash.html fast/dom/inline-event-attributes-lookup-removed.html fast/dom/Element/onclick-case.html fast/dom/inline-event-attributes-lookup.html fast/events/attribute-listener-cloned-from-frameless-doc-context.html fast/forms/access-key.html fast/dom/HTMLTableColElement/resize-table-using-col-width.html fast/dom/HTMLLabelElement/click-label.html fast/flexbox/line-clamp-link-after-ellipsis.html fast/events/attribute-listener-extracted-from-frameless-doc-context-2.html fast/events/attribute-listener-cloned-from-frameless-doc-context-2.html fast/events/attribute-listener-cloned-from-frameless-doc.xhtml editing/selection/focus-and-display-none.html fast/forms/label/label-becomes-visible-while-clicking-on-label.html fast/forms/radio/radio-group-keyboard-change-event.html fast/events/event-function-toString.html fast/dom/search-shadow-host-crash.html

Build Bot

Comment 8 2013-09-14 04:19:52 PDT

Created attachment 211642 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Darin Adler

Comment 9 2013-09-14 09:18:09 PDT

Committed r155769: <http://trac.webkit.org/changeset/155769>

Note You need to log in before you can comment on or make changes to this bug.