Bug 121345

Summary: CTTE: RenderSVGResourceMarker always has an SVGMarkerElement.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, esprehn+autocc, fmalita, glenn, kling, kondapallykalyan, pdr, schenney
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2013-09-13 22:38:20 PDT 
CTTE: RenderSVGResourceMarker always has an SVGMarkerElement.
Comment 1 Andreas Kling 2013-09-13 22:40:13 PDT 
Created attachment 211622 [details]
Patch
Comment 2 Brent Fulgham 2013-09-13 23:03:20 PDT 
Comment on attachment 211622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211622&action=review

r=me. I had question about the "renderName" method, but otherwise it looks good to me.

> Source/WebCore/rendering/svg/RenderSVGResourceMarker.h:38
> +    explicit RenderSVGResourceMarker(SVGMarkerElement&);

Yes!

> Source/WebCore/rendering/svg/RenderSVGResourceMarker.h:-41
> -    virtual const char* renderName() const { return "RenderSVGResourceMarker"; }

Is this stuff not needed for printing render tree dumps?
Comment 3 Andreas Kling 2013-09-13 23:30:27 PDT 
Comment on attachment 211622 [details]
Patch

Clearing flags on attachment: 211622

Committed r155750: <http://trac.webkit.org/changeset/155750>
Comment 4 Andreas Kling 2013-09-13 23:30:33 PDT 
All reviewed patches have been landed.  Closing bug.