Bug 121322

Summary: Use nullptr instead of 0 in calls to HashMap::add
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, dstockwell, esprehn+autocc, glenn, japhet, kangil.han, macpherson, menard, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2013-09-13 14:23:07 PDT
Use nullptr instead of 0 in calls to HashMap::add
Attachments
Patch (29.47 KB, patch)
2013-09-13 14:24 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-09-13 14:24:08 PDT
Created attachment 211590 [details] Patch
WebKit Commit Bot
Comment 2 2013-09-13 14:27:02 PDT
Attachment 211590 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp', u'Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp', u'Source/WebCore/ChangeLog', u'Source/WebCore/bridge/IdentifierRep.cpp', u'Source/WebCore/css/CSSFontFaceSource.cpp', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSSegmentedFontFace.cpp', u'Source/WebCore/css/CSSValuePool.cpp', u'Source/WebCore/dom/ChildListMutationScope.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/NodeRareData.h', u'Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp', u'Source/WebCore/page/PageGroup.cpp', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/platform/mac/ScrollbarThemeMac.mm', u'Source/WebCore/storage/StorageNamespaceImpl.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/NetscapePluginHostManager.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/Connection.cpp', u'Source/WebKit2/UIProcess/Storage/StorageManager.cpp', u'Source/WebKit2/UIProcess/WebProcessProxy.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp', u'Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp', u'Source/WebKit2/WebProcess/WebProcess.cpp', u'Tools/ChangeLog', u'Tools/DumpRenderTree/mac/TestRunnerMac.mm', u'Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp']" exit_code: 1 Source/WebKit2/UIProcess/Storage/StorageManager.cpp:445: Missing spaces around >> [whitespace/operators] [3] Source/WebKit2/UIProcess/Storage/StorageManager.cpp:478: Missing spaces around >> [whitespace/operators] [3] Source/WebKit2/UIProcess/Storage/StorageManager.cpp:619: Missing spaces around >> [whitespace/operators] [3] Source/WebKit2/WebProcess/WebProcess.cpp:577: Missing spaces around >> [whitespace/operators] [3] Source/WebKit2/WebProcess/WebProcess.cpp:729: Missing spaces around >> [whitespace/operators] [3] Total errors found: 5 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2013-09-13 16:05:07 PDT
Committed r155729: <http://trac.webkit.org/changeset/155729>
Note You need to log in before you can comment on or make changes to this bug.