Bug 121306

Summary: Remove layering-violating Pasteboard::writeURL (for all platforms now)
Product: WebKit Reporter: Darin Adler <darin>
Component: HTML EditingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: fred.wang, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch koivisto: review+, webkit-ews: commit-queue-

Darin Adler
Reported 2013-09-13 10:20:57 PDT
Remove layering-violating Pasteboard::writeURL (for all platforms now)
Attachments
Patch (14.76 KB, patch)
2013-09-13 10:37 PDT, Darin Adler 		koivisto: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-09-13 10:37:07 PDT
Created attachment 211562 [details] Patch
Antti Koivisto
Comment 2 2013-09-13 10:42:38 PDT
Comment on attachment 211562 [details] Patch r=me
Early Warning System Bot
Comment 3 2013-09-13 10:43:42 PDT
Comment on attachment 211562 [details] Patch Attachment 211562 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1848055
Darin Adler
Comment 4 2013-09-13 10:45:09 PDT
Committed r155709: <http://trac.webkit.org/changeset/155709>
Frédéric Wang (:fredw)
Comment 5 2013-09-13 22:24:31 PDT
This fails to build in Debug mode (GTK): Pasteboard::write should have - ASSERT(!url.isEmpty()); + ASSERT(!pasteboardURL.url.isEmpty()); I guess.
Note You need to log in before you can comment on or make changes to this bug.