Bug 121286

Summary:

[CTTE] RenderTableCol is never anonymous.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kangil.han, kling, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+
Patch	none

Description Andreas Kling 2013-09-13 03:28:24 PDT

[CTTE] RenderTableCol is never anonymous.

Comment 1 Andreas Kling 2013-09-13 03:28:42 PDT

Created attachment 211529 [details]
Patch

Comment 2 Antti Koivisto 2013-09-13 03:55:18 PDT

Comment on attachment 211529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211529&action=review

> Source/WebCore/rendering/RenderListItem.cpp:104
> -    Element* listItemNode = listItem->element();
> +    Element& listItemNode = listItem->existingElement();

Could name local to *Element since you are here.

Comment 3 Andreas Kling 2013-09-13 03:56:53 PDT

Created attachment 211532 [details]
Patch

Comment 4 Andreas Kling 2013-09-13 04:15:33 PDT

Comment on attachment 211532 [details]
Patch

Clearing flags on attachment: 211532

Committed r155685: <http://trac.webkit.org/changeset/155685>

Comment 5 Andreas Kling 2013-09-13 04:15:40 PDT

All reviewed patches have been landed.  Closing bug.