Bug 121278

Summary:

[CTTE] RenderFileUploadControl always has a HTMLInputElement.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Forms

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Andreas Kling 2013-09-12 23:24:00 PDT

[CTTE] RenderFileUploadControl always has a HTMLInputElement.

Comment 1 Andreas Kling 2013-09-12 23:24:32 PDT

Created attachment 211514 [details]
Patch

Comment 2 Darin Adler 2013-09-13 00:53:50 PDT

Comment on attachment 211514 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211514&action=review

> Source/WebCore/rendering/RenderFileUploadControl.h:47
> +    virtual bool isFileUploadControl() const OVERRIDE { return true; }

We don’t have to shout OVERRIDE any more. Apparently we do need to yell when saying FINAL, though.

Comment 3 Andreas Kling 2013-09-13 02:42:49 PDT

Committed r155681: <http://trac.webkit.org/changeset/155681>