Bug 121270
| Summary: | Web Inspector: InspectorOverlayPage_html should have minified css and js | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> |
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | graouts, joepeck, rniwa, timothy, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Joseph Pecoraro
As rniwa discovered in bug 121183 these serialized files can be rather large if not compressed before being packed into the WebCore binary. We should minify the css / js in this simple HTML file.
shell> symbols Release/WebCore.framework/WebCore | sed -E 's/^ *0x[0-9a-f]+ *\(( *)0x([^)]+)\)/\1\2/' | sort -r | head -n 30
...
4880 InspectorOverlayPage_html [NameNList, MangledNameNList, NList]
…
This is 18.3kb. Minifying the JS and CSS we can do better.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/14981831>
Joseph Pecoraro
before: 18.13k
4880 InspectorOverlayPage_html [NameNList, MangledNameNList, NList]
after: 13.97k
37e0 InspectorOverlayPage_html [NameNList, MangledNameNList, NList]
And just the generated size on disk:
84K InspectorOverlayPage-after.h
109K InspectorOverlayPage-before.h
Joseph Pecoraro
Due to the prior failure. I just rolled this into bug 121183.
*** This bug has been marked as a duplicate of bug 121183 ***