Bug 121265

Summary: Web Inspector: Duplicated color swatches changing autocompletes color names
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix - Better Code Style none

Joseph Pecoraro
Reported 2013-09-12 14:57:25 PDT
This is a REGRESSION due to CodeMirror supporting multiple bookmarks at the same position. <https://github.com/marijnh/CodeMirror/commit/96400e8fc7a3d7303715d03078350036fc6f6743> I'll investigate a fix. I likely broke this in an earlier CodeMirror update.
Attachments
[PATCH] Proposed Fix (6.28 KB, patch)
2013-09-12 15:28 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix - Better Code Style (6.28 KB, patch)
2013-09-12 15:48 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-09-12 14:57:46 PDT
<rdar://problem/14979488>
Joseph Pecoraro
Comment 2 2013-09-12 15:26:51 PDT
* STEPS TO REPRODUCE 1. Inspect <p> on data:text/html,<p>test 2. In the styles sidebar start typing: "color: b|" 3. Go up/down completion list => duplicate swatches appear * NOTES This also causes problems with checkbox bookmarks.
Joseph Pecoraro
Comment 3 2013-09-12 15:28:40 PDT
Created attachment 211482 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 4 2013-09-12 15:48:00 PDT
Created attachment 211485 [details] [PATCH] Proposed Fix - Better Code Style
WebKit Commit Bot
Comment 5 2013-09-12 16:29:20 PDT
Comment on attachment 211485 [details] [PATCH] Proposed Fix - Better Code Style Clearing flags on attachment: 211485 Committed r155661: <http://trac.webkit.org/changeset/155661>
WebKit Commit Bot
Comment 6 2013-09-12 16:29:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.