Bug 121262

Summary: Web Inspector: Update CodeMirror for gutter fix
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2013-09-12 14:48:12 PDT
Update CodeMirror to 757944449: <https://github.com/marijnh/CodeMirror/commit/7579444498ba0db844f4921ee59a5dbaed9f93d0> Desired to pick up the following fix: <https://github.com/marijnh/CodeMirror/issues/1807> <https://github.com/marijnh/CodeMirror/commit/30a9ee56fe988d54e3bdd435f7c37af68c5c4c21> • PrettyPrinting tests pass and performance looks good • Mode "css-base" was renamed to "css" and required minor fixes for our "css-rule" mode • Tested forced jsmin build to ensure production builds should be good • Otherwise things looked good!
Attachments
[PATCH] Proposed Fix (48.56 KB, patch)
2013-09-12 14:49 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-09-12 14:48:32 PDT
<rdar://problem/14979366>
Joseph Pecoraro
Comment 2 2013-09-12 14:49:43 PDT
Created attachment 211479 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2013-09-12 16:27:02 PDT
Comment on attachment 211479 [details] [PATCH] Proposed Fix Clearing flags on attachment: 211479 Committed r155659: <http://trac.webkit.org/changeset/155659>
WebKit Commit Bot
Comment 4 2013-09-12 16:27:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.