Bug 121250

Summary: GPRTemporary's reuse constructor should be templatized to reduce code duplication, and the bool to denote tag or payload should be replaced with an enum
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 121064    
Attachments:
Description Flags
the patch oliver: review+

Description Filip Pizlo 2013-09-12 13:01:26 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-09-12 13:02:06 PDT 
Created attachment 211462 [details]
the patch
Comment 2 Filip Pizlo 2013-09-12 13:06:23 PDT 
Landed in http://trac.webkit.org/changeset/155643
Comment 3 Ryosuke Niwa 2013-09-12 14:08:36 PDT 
Qt build fixed in http://trac.webkit.org/changeset/155649 for

/ramdisk/qt-linux-release/build/Source/JavaScriptCore/dfg/DFGGPRInfo.h: In member function 'JSC::DFG::GPRReg JSC::DFG::JSValueRegs::gpr(JSC::WhichValueWord) const':
[1;31m/ramdisk/qt-linux-release/build/Source/JavaScriptCore/dfg/DFGGPRInfo.h:169:5: error: control reaches end of non-void function [-Werror=return-type][0m
cc1plus: all warnings being treated as errors

I've sent out a complaint about the warning. It's totally bogus.