Bug 121241

Summary: [EFL] Get rid of layering violations in PasteboardEfl.cpp
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, gyuyoung.kim, laszlo.gombos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2013-09-12 11:05:13 PDT
We should get rid of layering violations in PasteboardEfl.cpp to help with the ongoing effort. It should be easy for us as we do not support Pasteboard yet.
Attachments
Patch (12.83 KB, patch)
2013-09-12 11:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.53 KB, patch)
2013-09-12 12:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-09-12 11:11:21 PDT
Created attachment 211448 [details] Patch
Darin Adler
Comment 2 2013-09-12 11:46:40 PDT
Comment on attachment 211448 [details] Patch Thanks, this is helpful.
WebKit Commit Bot
Comment 3 2013-09-12 11:48:53 PDT
Comment on attachment 211448 [details] Patch Rejecting attachment 211448 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 211448, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: le Source/WebCore/editing/efl/EditorEfl.cpp patching file Source/WebCore/page/DragController.cpp patching file Source/WebCore/platform/Pasteboard.h Hunk #1 FAILED at 170. Hunk #2 FAILED at 195. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/Pasteboard.h.rej patching file Source/WebCore/platform/efl/PasteboardEfl.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/1855022
Chris Dumez
Comment 4 2013-09-12 12:14:49 PDT
Created attachment 211456 [details] Patch
WebKit Commit Bot
Comment 5 2013-09-12 12:18:31 PDT
Comment on attachment 211456 [details] Patch Rejecting attachment 211456 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 211456, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ching file Source/WebCore/editing/Editor.h patching file Source/WebCore/editing/efl/EditorEfl.cpp patching file Source/WebCore/page/DragController.cpp patching file Source/WebCore/platform/Pasteboard.h Hunk #1 FAILED at 142. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/Pasteboard.h.rej patching file Source/WebCore/platform/efl/PasteboardEfl.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/1857130
Darin Adler
Comment 6 2013-09-12 12:22:13 PDT
Committed r155638: <http://trac.webkit.org/changeset/155638>
Chris Dumez
Comment 7 2013-09-12 12:22:41 PDT
Reopening to attach new patch.
Chris Dumez
Comment 8 2013-09-12 12:23:31 PDT
Thanks for rebasing / landing.
Note You need to log in before you can comment on or make changes to this bug.