Bug 121228

Summary: [Qt] Add git repository support to Qt's "maybe clean build needed" detector script
Product: WebKit Reporter: Ádám Kallai <kadam>
Component: Tools / TestsAssignee: Ádám Kallai <kadam>
Status: RESOLVED FIXED    
Severity: Normal CC: abrhm, allan.jensen, commit-queue, dbates, jturcotte, ossy, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
draft patch none

Ádám Kallai
Reported 2013-09-12 08:24:25 PDT
Unfortunately QtWebKit build system doesn't support git repository properly. The problem is that when the build system checks what are the differences in project files between previous and current change. The build system search changes by SVN revision. But SVN revision isn't in git repository or in different order because of cherry-picking from trunk. This bug made incremental build terrible slow(15 minutes on Linux and 5+ hours on Windows), because git-svn calls tried to rebuild the non-existent SVN history.
Attachments
Patch (6.90 KB, patch)
2013-09-12 09:40 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
draft patch (4.57 KB, patch)
2013-09-12 09:52 PDT, Ádám Kallai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-09-12 09:22:45 PDT
I have something that might do the trick. Do we also need SVN support for some of the official bots?
Ádám Kallai
Comment 2 2013-09-12 09:30:06 PDT
My fix is almost done. I'm going to upload as soon as possible. I think we need SVN support.
Allan Sandfeld Jensen
Comment 3 2013-09-12 09:40:09 PDT
Created attachment 211437 [details] Patch
Ádám Kallai
Comment 4 2013-09-12 09:52:05 PDT
Created attachment 211438 [details] draft patch I should test this patch. If It is good then I'm going to upload for review.
Ádám Kallai
Comment 5 2013-09-12 09:54:18 PDT
Sorry, I didn't refresh the page. It seems I was slow.
Allan Sandfeld Jensen
Comment 6 2013-09-12 10:10:02 PDT
(In reply to comment #5) > Sorry, I didn't refresh the page. It seems I was slow. Sorry, maybe I was too fast. I had something half working when you opened the bug.
Allan Sandfeld Jensen
Comment 7 2013-09-13 06:12:46 PDT
For now we will land this in our branch. If any other ports want to use the code we can land it in trunk as well.
Anders Carlsson
Comment 8 2013-10-02 21:42:08 PDT
Comment on attachment 211437 [details] Patch Qt has been removed, clearing review flags.
Allan Sandfeld Jensen
Comment 9 2013-10-03 05:04:39 PDT
Solved in qt5x2 branch, will not be pushed upstream.
Note You need to log in before you can comment on or make changes to this bug.