Bug 121185

Summary: Avoid copying a hash table bucket when inserting causes a rehash
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Anders Carlsson
Reported 2013-09-11 15:09:10 PDT
Avoid copying a hash table bucket when inserting causes a rehash
Attachments
Patch (6.66 KB, patch)
2013-09-11 15:11 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-09-11 15:11:21 PDT
Created attachment 211358 [details] Patch
Darin Adler
Comment 2 2013-09-11 15:13:36 PDT
Comment on attachment 211358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211358&action=review > Source/WTF/ChangeLog:8 > + Allow rehahsing to track a hash bucket and return the new pointer to it, thus avoiding typo: rehashing > Source/WTF/wtf/HashTable.h:-940 > - // FIXME: This makes an extra copy on expand. Probably not that bad since > - // expand is rare, but would be better to have a version of expand that can > - // follow a pivot entry and return the new position. You fixed this FIXME!
Anders Carlsson
Comment 3 2013-09-11 15:26:30 PDT
Committed r155571: <http://trac.webkit.org/changeset/155571>
Note You need to log in before you can comment on or make changes to this bug.