|Summary:||autogen.sh: fix removal of autom4te.cache|
|Product:||WebKit||Reporter:||Alberto Garcia <berto>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Version:||528+ (Nightly build)|
Description Alberto Garcia 2013-09-11 03:20:55 PDT
autom4te.cache doesn't harm other than taking a bit of space in the hard drive. It can be safely removed anyway. However at the moment we have rm -f $top_srcdir/autom4te.cache which doesn't work since 1) autom4te.cache is a directory 2) $top_srcdir is not defined in autogen.sh Best case, that's equivalent to rm -f /autom4te.cache, which does nothing since that file doesn't exist. Worst case, the user has $top_srcdir set to some value and funny surprises happen. Since we can guarantee that we're in the root directory of the WebKit tree we can just run rm -rf autom4te.cache And this should be run _after_ autoreconf since it's not needed by anyone else.
Comment 2 Carlos Garcia Campos 2013-09-11 03:28:49 PDT
Comment on attachment 211293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211293&action=review Thanks! > ChangeLog:9 > + Fix incorrect removal of autom4te.cache and put it after the > + autoreconf call. Could you briefly explain here why it was wrong, the explanation in the bug summary is great.