Bug 121143

Summary: Rename BackForwardList => BackForwardClient.
Product: WebKit Reporter: Andreas Kling <kling>
Component: HistoryAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, kling, rakuco, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+, webkit-ews: commit-queue-
Land? none

Description Andreas Kling 2013-09-10 23:47:32 PDT 
FIXME from 2010.
Comment 1 Andreas Kling 2013-09-10 23:52:54 PDT 
Created attachment 211284 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-10 23:55:04 PDT 
Attachment 211284 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/history/BackForwardController.cpp', u'Source/WebCore/history/BackForwardController.h', u'Source/WebCore/history/BackForwardList.h', u'Source/WebCore/history/BackForwardListImpl.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.h']" exit_code: 1
Source/WebCore/history/BackForwardList.h:28:  #ifndef header guard has wrong style, please use: BackForwardList_h  [build/header_guard] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-09-10 23:59:54 PDT 
Comment on attachment 211284 [details]
Patch

Attachment 211284 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1729910
Comment 4 Early Warning System Bot 2013-09-11 00:02:16 PDT 
Comment on attachment 211284 [details]
Patch

Attachment 211284 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1736794
Comment 5 Andreas Kling 2013-09-11 00:03:38 PDT 
Created attachment 211285 [details]
Land?
Comment 6 WebKit Commit Bot 2013-09-11 00:06:18 PDT 
Attachment 211285 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/history/BackForwardController.cpp', u'Source/WebCore/history/BackForwardController.h', u'Source/WebCore/history/BackForwardList.h', u'Source/WebCore/history/BackForwardListImpl.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/webkit/webkitwebbackforwardlist.cpp', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.h']" exit_code: 1
Source/WebCore/history/BackForwardList.h:28:  #ifndef header guard has wrong style, please use: BackForwardList_h  [build/header_guard] [5]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Andreas Kling 2013-09-11 00:35:43 PDT 
Comment on attachment 211285 [details]
Land?

Clearing flags on attachment: 211285

Committed r155504: <http://trac.webkit.org/changeset/155504>
Comment 8 Andreas Kling 2013-09-11 00:35:50 PDT 
All reviewed patches have been landed.  Closing bug.